Help text doesn't match functionality for "My groups" sidebar list

Bug #1377371 reported by Kristina Hoeppner on 2014-10-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.10
High
Robert Lyon
15.04
High
Robert Lyon

Bug Description

Mahara 1.10 RC1

On /accounts/index.php it says "Leave blank to show all your groups." for the "Maximum number of groups to display" setting. However, when you leave the box empty and save the page, it puts a 0 in there. This is counter intuitive and also does not reflect the functionality in the "My groups" block where it is left empty indeed.

Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Robert Lyon (robertl-9) on 2014-10-05
Changed in mahara:
status: Confirmed → In Progress
Eduardo (o-eduardo) wrote :

Testing on "master" branch. Before Patch the "My groups" sidebar default setting was "0" and not blank, meaning all groups were showing. After Patch the default setting was "blank" AND when "0" was selected no groups were showing on the sidebar. Below are the steps I took:

Logged in as admin.
Go to Groups
Create Group called “Testing Group 1”
Save group
 Go to Settings
Go to Maximum number of groups to display
Delete “0” and leave it blank
Save settings
Refresh page
The number “0” should be shown
And My groups sidebar should be showing “Testing Group 1”

Reviewed: https://reviews.mahara.org/3745
Committed: http://gitorious.org/mahara/mahara/commit/becb809b34e1746284d1ac5f92f003e102ca95cb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit becb809b34e1746284d1ac5f92f003e102ca95cb
Author: Robert Lyon <email address hidden>
Date: Mon Oct 6 09:59:35 2014 +1300

Allowing groupsideblockmaxgroups to be set as blank (Bug #1377371)

Also allow a text field to change from 0 to blank. Currently it doesn't
update the user even though they are different.

Change-Id: I4dcc9dd469ec7525c80c29f0207487d8f26fff34
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/3785
Committed: http://gitorious.org/mahara/mahara/commit/6c3e1cc70a401721efe6c8b6be3538138a5a97c5
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 6c3e1cc70a401721efe6c8b6be3538138a5a97c5
Author: Robert Lyon <email address hidden>
Date: Mon Oct 6 09:59:35 2014 +1300

Allowing groupsideblockmaxgroups to be set as blank (Bug #1377371)

Also allow a text field to change from 0 to blank. Currently it doesn't
update the user even though they are different.

Change-Id: I4dcc9dd469ec7525c80c29f0207487d8f26fff34
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers