Pieform form maharatable renderer doesn't respect the isescaped flag

Bug #1375521 reported by Robert Lyon on 2014-09-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon
1.10
Medium
Robert Lyon
15.04
Medium
Robert Lyon

Bug Description

When setting errors on a pieform via the $form->set_error() function the lib/form/renderers/maharatable.php doesn't respect the third flag isescaped

Jinelle Foley-Barnes (jinelleb) wrote :

Hi,

I tested this on the master branch. Pre patch, the error message had span tags showing. Post patch the span tags were gone and the error message showed "This field is required".

Patch successful :)

Manual test method is as follows:

-Log in as Admin
-Portfolio
-Pages
-Create a page
-Save
-External drop down lin
-External feed
-Save
-I left the URL field "*required" empty
-Save

Cheers,
Jinelle

Reviewed: https://reviews.mahara.org/3731
Committed: http://gitorious.org/mahara/mahara/commit/57acef1341436a6fd6031728ed852ded399d4f7f
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 57acef1341436a6fd6031728ed852ded399d4f7f
Author: Robert Lyon <email address hidden>
Date: Tue Sep 30 14:01:20 2014 +1300

Allowing the isescaped flag to be observed for form errors (Bug 1375521)

Change-Id: I41e6be9d6cc6956e161ea895280c238d5f3e2907
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/3782
Committed: http://gitorious.org/mahara/mahara/commit/4bf0abfc282faa4990044a84cf20f6ba75c2bd02
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 4bf0abfc282faa4990044a84cf20f6ba75c2bd02
Author: Robert Lyon <email address hidden>
Date: Tue Sep 30 14:01:20 2014 +1300

Allowing the isescaped flag to be observed for form errors (Bug 1375521)

Change-Id: I41e6be9d6cc6956e161ea895280c238d5f3e2907
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers