Missing plugins not disabled cleanly.

Bug #1373226 reported by Nigel Cunningham on 2014-09-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Nigel Cunningham
15.04
Medium
Nigel Cunningham

Bug Description

While working on bug505732, I've found that having data but not files for a plugin results in the same errors described in bug629209 (Mahara: Site unavailable. A nonrecoverable error occured. This probably means you have encountered a bug in the system).

This is because the plugin isnot marked inactive when the safe_require fails, and later code doesn't check whether a plugin is active before attempting to again require and use the plugin.

With the patch that I intend to submit to Gerrit, the page is loaded as normal, with the missingplugindisabled message included.

(Currently tested with the extensions page; I've seen that I need to make further changes to cover other cases where the plugin is also used without the active flag being checked).

Aaron Wells (u-aaronw) wrote :

This probably explains all the mysterious cases of "A nonrecoverable error occurred" that I've been having as I switch around between different gerrit patches lately, since we just added the "blocktype/text" plugin via db/upgrade.php.

Hi.

I've just pushed a patch for testing to Gerrit. I haven't yet done a
thorough search of the source to see whether there are other cases I
need to check for but this seems to do the trick for most pages.

Hopefully it will help you for now, Aaron.

Regards,

Nigel

On 24/09/14 15:30, Aaron Wells wrote:
> This probably explains all the mysterious cases of "A nonrecoverable
> error occurred" that I've been having as I switch around between
> different gerrit patches lately, since we just added the
> "blocktype/text" plugin via db/upgrade.php.
>

Aaron Wells (u-aaronw) on 2014-10-08
Changed in mahara:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 1.10.0
Robert Lyon (robertl-9) on 2014-10-12
Changed in mahara:
milestone: 1.10.0 → 1.10.1
no longer affects: mahara/1.10

Reviewed: https://reviews.mahara.org/3719
Committed: http://gitorious.org/mahara/mahara/commit/14439aca7bd8728bfcf59a94e50505e4956b0ed5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 14439aca7bd8728bfcf59a94e50505e4956b0ed5
Author: Nigel Cunningham <email address hidden>
Date: Wed Sep 24 14:54:12 2014 +1000

Bug1373226 Fix handling of missing plugin.

Fix the handling of disabling a plugin when we find that the files
for a module are missing.

Change-Id: I706a9c4fd3c86fb1a0e330bb77c40d5e6d888a52
Signed-off-by: Nigel Cunningham <email address hidden>

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers