upgrade problem with having the settings array
Bug #1372188 reported by
Robert Lyon
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Robert Lyon |
Bug Description
Now that we have a 'settings' array in check_upgrades() (see Bug 1367998) it can never return false so if we do something like
if ($data = check_upgrades(
}
it will fail if it's already installed as it returns the 'settings' array
So we need to add to the upgrade_plugin() function a check to see if $upgrade->name has been passed otherwise bail out
tags: | added: regression |
description: | updated |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Patch for "master" branch: https:/ /reviews. mahara. org/3708