Clean expired passwords causes error when upgrading from 1.8
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Ghada El-Zoghbi | ||
1.10 |
Fix Released
|
High
|
Unassigned | ||
1.9 |
Fix Released
|
High
|
Unassigned | ||
15.04 |
Fix Released
|
High
|
Ghada El-Zoghbi |
Bug Description
Mahara: 1.10.0dev
OS: Linux
DB: Postgres
Browser: any
The change put in to fix the cleaning of expired passwords has introduced a bug that causes a duplicate error when trying to upgrade from 1.8 to 1.10.
[WAR] b8 (lib/errors.
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] [WAR] b8 (lib/errors.
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] [WAR] b8 (lib/errors.
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] Call stack (most recent first):, referer: http://
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] * log_message("Failed to get a recordset: postgres7 error: [-5: E...", 8, true, true) at /var/www/
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] * log_warn("Failed to get a recordset: postgres7 error: [-5: E...") at /var/www/
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] * SQLException-
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] * insert_
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] * ensure_
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] * xmldb_core_
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] * upgrade_
[Mon Sep 15 11:44:24 2014] [error] [client 192.168.124.138] , referer: http://
The reason is because the check if the record exists needs to pass a $where array that doesn't include the items to be updated.
i.e. $where = array('
Changed in mahara: | |
status: | New → In Progress |
Changed in mahara: | |
milestone: | none → 1.10.0 |
importance: | Undecided → High |
tags: | added: regression |
Changed in mahara: | |
milestone: | 1.10.0 → 1.10.1 |
no longer affects: | mahara/1.8 |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Related to this bug:
https:/ /bugs.launchpad .net/mahara/ +bug/1296472
Probably need to perform same fix in 1.8 and 1.9.