Add to collection popup message odd on first addition

Bug #1369343 reported by Robert Lyon on 2014-09-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.10
High
Unassigned
15.04
High
Robert Lyon

Bug Description

On the "allow collection's page list to be drag/drop sortable" page I found
that when I added the first page to a collection and that already had
some permissions set, the page was not listed in the pop-up "Access
permissions changed for the following pages." It just had that text, but
no pages.

This only happens when drag/dropping a page into the collection - if I add the first page to a collection via ticking the checkbox and clicking 'add pages' I do not get this popup message.

So what needs to be done is see how the json way of updating the page is different to the form way of doing it.

Robert Lyon (robertl-9) on 2014-09-14
Changed in mahara:
importance: Low → High
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 1.10.1
Changed in mahara:
milestone: 1.10.1 → 1.11.0
milestone: 1.11.0 → 1.10.0

Reviewed: https://reviews.mahara.org/3694
Committed: http://gitorious.org/mahara/mahara/commit/068c63b1a7afb182bdc68fad082779325980b854
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 068c63b1a7afb182bdc68fad082779325980b854
Author: Robert Lyon <email address hidden>
Date: Mon Sep 15 10:29:46 2014 +1200

Adding first page to collection via json not to alert (Bug 1369343)

When adding the first page to a collection via drag/drop the alert
pops up saying you are change page permissions - but that isn't true.

Change-Id: Icacbd3c131e13bb216eba0d8a15de000b702686c
Signed-off-by: Robert Lyon <email address hidden>

Son Nguyen (ngson2000) on 2014-10-06
Changed in mahara:
status: Confirmed → Fix Committed

Reviewed: https://reviews.mahara.org/3765
Committed: http://gitorious.org/mahara/mahara/commit/f6005f6773f03f21f714b58c75fe19e4e74d7fe0
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit f6005f6773f03f21f714b58c75fe19e4e74d7fe0
Author: Robert Lyon <email address hidden>
Date: Mon Sep 15 10:29:46 2014 +1200

Adding first page to collection via json not to alert (Bug 1369343)

When adding the first page to a collection via drag/drop the alert
pops up saying you are change page permissions - but that isn't true.

Change-Id: Icacbd3c131e13bb216eba0d8a15de000b702686c
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers