width of gallery not set correctly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Robert Lyon | ||
1.10 |
Fix Released
|
Medium
|
Robert Lyon | ||
1.9 |
Fix Released
|
Medium
|
Robert Lyon | ||
15.04 |
Fix Released
|
Medium
|
Robert Lyon |
Bug Description
When creating an image gallery, a user can 'blank' out the 'Width' field.
When the block is instantiated, the $configdata[
So, the $width is also empty.
i.e. $width = isset($
I think the switch at the top should also check for '&& $configdata[
i.e.
switch ($style) {
case 0: // thumbnails
$template = 'thumbnails';
$width = isset($
break;
case 1: // slideshow
$template = 'slideshow';
$width = isset($
break;
case 2: // square thumbnails
//default:
$template = 'squarethumbs';
$width = isset($
break;
}
Hope that makes sense.
Changed in mahara: | |
assignee: | nobody → Robert Lyon (robertl-9) |
milestone: | none → 1.10.0 |
status: | Confirmed → In Progress |
Changed in mahara: | |
milestone: | 1.10.0 → 1.10.1 |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/3686