ArtfactType::commit - don't delete records when none exist

Bug #1364669 reported by Nigel Cunningham on 2014-09-02
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

In ArtefactType::commit, we shouldn't bother calling delete_records if we know the artefact that is being committed is new. In testing the addition 2000 users from a CSV file, this patch shaved 4 seconds off the completion time.

Changed in mahara:
assignee: nobody → Nigel Cunningham (nigelc-g)
status: New → In Progress
Changed in mahara:
importance: Undecided → Medium
tags: added: performance
Changed in mahara:
assignee: Nigel Cunningham (nigelc-g) → nobody
status: In Progress → Confirmed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers