Mahara

ArtfactType::commit - don't delete records when none exist

Bug #1364669 reported by Nigel Cunningham on 2014-09-02

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Confirmed	Medium	Unassigned

Bug Description

In ArtefactType::commit, we shouldn't bother calling delete_records if we know the artefact that is being committed is new. In testing the addition 2000 users from a CSV file, this patch shaved 4 seconds off the completion time.

Tags:

Nigel Cunningham (nigelc-g) on 2014-09-02

Changed in mahara:
assignee:	nobody → Nigel Cunningham (nigelc-g)
status:	New → In Progress

Kristina Hoeppner (kris-hoeppner) on 2014-09-03

Changed in mahara:
importance:	Undecided → Medium

Nigel Cunningham (nigelc-g) on 2014-09-15

tags:

added: performance

Kristina Hoeppner (kris-hoeppner) on 2019-05-25

Changed in mahara:
assignee:	Nigel Cunningham (nigelc-g) → nobody
status:	In Progress → Confirmed

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.