Mahara

Skins fetching of default 'no thumb' thumb image problem

Bug #1362410 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon
Mahara 1.10.0

Bug Description

Currently the 'no thumb' image is fetched via a web url - but that causes problems if the site is behind basic auth.

But it doesn't have to be fetch via web url as the file lives on the same server as everything else so it can be fetch via filepath instead - which I recon is the better way to do it.

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 1.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3670

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3670
Committed: http://gitorious.org/mahara/mahara/commit/8ecd75be00392b5e716f574050c8219e34ba8f6a
Submitter: Ghada El-Zoghbi (<email address hidden>)
Branch: master

commit 8ecd75be00392b5e716f574050c8219e34ba8f6a
Author: Robert Lyon <email address hidden>
Date: Thu Aug 28 16:19:42 2014 +1200

Fetching the default skin thumb in a better way (Bug #1362410)

Change-Id: Ic4d942b9d058dbf2125600bc025a2a71ad28d099
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.