In admin extensions the save_config_options function lacks the $form attribute

Bug #1360943 reported by Robert Lyon on 2014-08-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon

Bug Description

There is no easy way to do a specific $form->json_reply() when saving an Admin -> Extensions config form.

For each plugin it defaults to a generic 'Saved successfully'.

I plan to adjust how this works so that it passes in the Pieform $form so that one can specify a special return success message, or default to generic one if no special one supplied.

This is needed for Bug 1339113.

Reviewed: https://reviews.mahara.org/3659
Committed: http://gitorious.org/mahara/mahara/commit/edd26c95385f67bec1a41c6d703c7589c39f28f1
Submitter: Ghada El-Zoghbi (<email address hidden>)
Branch: master

commit edd26c95385f67bec1a41c6d703c7589c39f28f1
Author: Robert Lyon <email address hidden>
Date: Mon Aug 25 12:15:23 2014 +1200

Adjusting the save_config_options() call to include $form (Bug #1360943)

To be more like the validate_config_options() call and so allow for
something other than the generic success message.

Change-Id: I36a6fec227c525776b58fd29c1548fb30b62a92c
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers