In admin extensions the save_config_options function lacks the $form attribute
Bug #1360943 reported by
Robert Lyon
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Robert Lyon |
Bug Description
There is no easy way to do a specific $form->json_reply() when saving an Admin -> Extensions config form.
For each plugin it defaults to a generic 'Saved successfully'.
I plan to adjust how this works so that it passes in the Pieform $form so that one can specify a special return success message, or default to generic one if no special one supplied.
This is needed for Bug 1339113.
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /reviews. mahara. org/3659 gitorious. org/mahara/ mahara/ commit/ edd26c95385f67b ec1a41c6d703c75 89c39f28f1
Committed: http://
Submitter: Ghada El-Zoghbi (<email address hidden>)
Branch: master
commit edd26c95385f67b ec1a41c6d703c75 89c39f28f1
Author: Robert Lyon <email address hidden>
Date: Mon Aug 25 12:15:23 2014 +1200
Adjusting the save_config_ options( ) call to include $form (Bug #1360943)
To be more like the validate_ config_ options( ) call and so allow for
something other than the generic success message.
Change-Id: I36a6fec227c525 776b58fd29c1548 fb30b62a92c
Signed-off-by: Robert Lyon <email address hidden>