Syntax error when using a logo by id for theme logo

Bug #1358912 reported by Robert Lyon on 2014-08-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Robert Lyon

Bug Description

The <link> tag url ends up with two ? in it - eg <link rel="image_src" href="http://test.site.com/thumb.php?type=logobyid&amp;id=174958?v=1.9.2">

It doesn't cause an error but is bad syntax so should be fixed

To test: edit an institution and add logo then login as a user from that institution - then view source of the page and look for 'image_src'

Robert Lyon (robertl-9) on 2014-08-19
Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/3648
Committed: http://gitorious.org/mahara/mahara/commit/13fbb849d3eade7dfd079f5703700c9d557f50e2
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 13fbb849d3eade7dfd079f5703700c9d557f50e2
Author: Robert Lyon <email address hidden>
Date: Wed Aug 20 08:21:46 2014 +1200

Fixing institution logo url call (Bug #1358912)

when one is using their own logo rather than default

Change-Id: I9cbf0b674e6a59bf108877a8f971e19b11cbb15a
Signed-off-by: Robert Lyon <email address hidden>

Son Nguyen (ngson2000) on 2014-08-26
Changed in mahara:
status: In Progress → Fix Committed
Son Nguyen (ngson2000) on 2014-08-27
Changed in mahara:
status: Fix Committed → In Progress

Reviewed: https://reviews.mahara.org/3668
Committed: http://gitorious.org/mahara/mahara/commit/42a3cc9624e8eb118c51439602fe85d270c931de
Submitter: Ghada El-Zoghbi (<email address hidden>)
Branch: master

commit 42a3cc9624e8eb118c51439602fe85d270c931de
Author: Son Nguyen <email address hidden>
Date: Wed Aug 27 16:33:34 2014 +1200

Use strpos() insteads of substr_count(). Bug 1358912

Change-Id: I68c42ecc0e9e3b03d3fd6e09468ce82407fdef70
Signed-off-by: Son Nguyen <email address hidden>

Robert Lyon (robertl-9) on 2014-08-31
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers