Allow image map to be rendered by htmlpurifier

Bug #1354286 reported by Robert Lyon on 2014-08-08
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon

Bug Description

Currently htmlpurifier strips out image map content (but tinymce accepts it).

I'll add a patch that will allow the image map code to be accepted by htmlpurifier

Reviewed: https://reviews.mahara.org/3625
Committed: http://gitorious.org/mahara/mahara/commit/10805bbf63a42b9e10400331910bd17b41b25a32
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 10805bbf63a42b9e10400331910bd17b41b25a32
Author: Robert Lyon <email address hidden>
Date: Fri Aug 8 18:35:20 2014 +1200

Adding the allowing of image map to htmlpurifier (Bug #1354286)

To test:
1) add an image map to a page
2) you may also need to add:
$config->set('Cache.DefinitionImpl', null);
to line 3252 of the lib/web.php page so the htmlpurifier cache is
ignored

Change-Id: I19ce97394ab52aea300cbf7c6b2c458ec7dcf5b9
Signed-off-by: Robert Lyon <email address hidden>

Ghada El-Zoghbi (ghada-z) wrote :

Hi,

I'm now getting the following error in the log files:

File does not exist: /var/www/maharacode/mahara/htdocs/theme/raw/static/images/site-logo.png&v=1.10.0dev, referer: http://d.mahara/view/index.php

This is with a vanilla Mahara 1.10.0dev with default theme.

It stems from the line in htdocs/lib/web.php line 479:

$sitelogo = $sitelogo . ((substr_count($sitelogo, '?') > 0) ? '?' : '&') . 'v=' . get_config('release');

Should I raise this as a seperate bug?

Thanks,
Ghada

Son Nguyen (ngson2000) wrote :

Thank Ghada,

I have pushed the patch https://reviews.mahara.org/3668 for this

Cheers,
Son

Aaron Wells (u-aaronw) on 2014-09-10
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers