Avoid making duplicate group categories

Bug #1353809 reported by Son Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Ivan Barreto

Bug Description

Version: master (1.10), 1.9, 1.8
Platform: any
Browser: any

Logged in as site admin, I can create duplicated group categories, see the screenshot

Tags: bite-sized
Revision history for this message
Son Nguyen (ngson2000) wrote :
Revision history for this message
Aaron Wells (u-aaronw) wrote : Re: Can make duplicate group categories

Marking this as low priority, because it's just giving admins the power to shoot themselves in the foot.

summary: - Group categories must be NOT duplicated
+ Group category names should have to be unique
summary: - Group category names should have to be unique
+ Can make duplicate group categories
Changed in mahara:
milestone: 1.10.0 → 1.11.0
importance: Undecided → Low
Changed in mahara:
milestone: 15.04.0 → none
tags: added: bite-sized
Changed in mahara:
assignee: nobody → Ivan Barreto (ivanbarreto)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10059

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Steven (stevens-q) wrote : Re: Can make duplicate group categories

Commit hash: ceb49805669b27277078ad4f0fce671d76c930de
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Allow group categories toggle = Yes (Site options > Group settings)

TEST STEPS:
------------------------
1) Log in as Site admin
2) Browse to Administration menu > Groups > Group categories
3) Add a category called Cat 1
4) Add a second category with the same name Cat 1
5) Verify that an error message is displayed as follows: "The value entered already exists" ✔
6) Verify that leaving the field blank also displays an error message as follows: "The required field "Name" is empty"✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10059
Committed: https://git.mahara.org/mahara/mahara/commit/b42035975c73e71dd3bc72b2b509723f67320793
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b42035975c73e71dd3bc72b2b509723f67320793
Author: Ivan Barreto <email address hidden>
Date: Thu May 30 10:09:04 2019 +1200

Bug #1353809: Avoid making duplicate group categories

This change stops one having duplicate group category entries.
We will do the comparison in a case insensitive way so we avoid
having: CatA, caTa, catA, cAta etc.

behatnotneeded

Change-Id: I2daafe898f78e78b0aa0b0bf2ffac29ea1b814e4

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 19.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10240

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10240
Committed: https://git.mahara.org/mahara/mahara/commit/4a5ce96d8421c7051a6b549d224b5baee3e386d3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4a5ce96d8421c7051a6b549d224b5baee3e386d3
Author: Robert Lyon <email address hidden>
Date: Mon Aug 5 08:22:23 2019 +1200

Bug #1353809: Show correct messages on error and success

To stop the error message still showing on success

Change-Id: Id8b618fbfd62d0610304a211ccfd777bb87e08c8
Signed-off-by: Robert Lyon <email address hidden>

summary: - Can make duplicate group categories
+ Avoid making duplicate group categories
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.