Comment 8 for bug 1353516

Robert Lyon (robertl-9) wrote :

This patch involves adding in a new user search setting so we end up with three settings relating to user search, which are:

[A] Users can hide real names: If checked, users who have set a display name may choose to be searchable only by their display name and will not be found in searches for their real name. (In the site administration section of the site, users are always searchable by their real names).

[B] Never display usernames: If checked, ordinary users will not be able to see the username of any other user.

[C] Search usernames: If checked, allow usernames to be searched on as part of "Search users".

So I believe there are 8 different permutations in play

1) [A] ticked
    [B] unticked
    [C] unticked

2) [A] ticked
    [B] ticked
    [C] unticked

3) [A] ticked
    [B] ticked
    [C] ticked

4) [A] ticked
    [B] unticked
    [C] ticked

5) [A] unticked
    [B] ticked
    [C] ticked

6) [A] unticked
    [B] ticked
    [C] unticked

7) [A] unticked
    [B] unticked
    [C] ticked

8) [A] unticked
    [B] unticked
    [C] unticked

Problems found when logged in as a normal user with admins settings in:

State 1,2,3, and 4:
- Can't actually search by displayname - even though the admin field description says we can
- Can search by real name - and real name is displayed in brackets next to displayname - so not actually hidden for those using displayname

State 5, 6, 7, 8:
- Worked as expected - thought being able to search by username and then not being able to display username (and visa versa) could be a bit confusing