Date fields

Bug #1348485 reported by Wangchen on 2014-07-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon

Bug Description

1) Date of birth can be a FUTURE date; for example: date of birth under resume accepts '2019/07/25'

2) Date fields accepts invalid characters/ special characters

3) Start and End date are not validated; for example: under employment/ education: Start date-25/07/2014 and End date-21/07/2002.

Kind Regards

Wangchen
University of Canberra

Robert Lyon (robertl-9) on 2014-07-28
Changed in mahara:
milestone: none → 1.10.0
assignee: nobody → Robert Lyon (robertl-9)
importance: Undecided → Medium
status: New → In Progress
Robert Lyon (robertl-9) wrote :

Hi Wangchen,

I agree there should be a check on Date of birth field to make sure that the date is not in the future. I'll add a patch for that.

But for the start / end dates under employment/education they are not true date fields but text tields as (unlike with ones date of birth) people forget when exactly things happened in their lives.

So putting in 'fall semester 1995' as a start date and 'graduated spring 1997' as an end date for one's university education would be perfectly valid but extremely hard to validate.

Cheers

Robert

Wangchen (tshering-wangchen) wrote :

Dear Robert,

Many thanks for the update.

Cheers

Wangchen

Reviewed: https://reviews.mahara.org/3520
Committed: http://gitorious.org/mahara/mahara/commit/554a89391884680c8b0dfa959fbe59aeadda035a
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 554a89391884680c8b0dfa959fbe59aeadda035a
Author: Robert Lyon <email address hidden>
Date: Tue Jul 29 11:27:46 2014 +1200

Need to check that resume dob is not in future (Bug #1348485)

As it makes no sense for the unborn to have a resume, as no one would
hire someone with experience :)

Change-Id: I1ef3482e84a2638a35174b0f32f9efbbc561c5ec
Signed-off-by: Robert Lyon <email address hidden>

As for the non-validated fields in the resume: That is on purpose as you don't always want to provide a hard date, but a soft one like the ones Robert mentioned.

Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers