bug: Profile progress bar disappears

Bug #1347362 reported by shanen on 2014-07-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.9
High
Robert Lyon

Bug Description

Mahara 1.9.1
Hi everyone,
I just discovered that in a case with multiple institutions the progress bar will not appear when an institution has not specified any completion criteria.

So, a use case where this would affect a user (see attached for screenshots)

user sees a progress bar for institution X. Institution X admin has set some criteria.
User changes institution to Y. Y has no criteria set - the block is blank and I can no longer change back to institution X.

A fix might be, regardless of whether or not criteria are set for the institution(s) show the title of the block and drop down of institutions.

Cheers.

Robert Lyon (robertl-9) on 2014-07-23
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 1.10.0
importance: Undecided → High
status: New → In Progress

Reviewed: https://reviews.mahara.org/3505
Committed: http://gitorious.org/mahara/mahara/commit/4a2e491e051b426dcdc2cf8342e40327b8498b5a
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 4a2e491e051b426dcdc2cf8342e40327b8498b5a
Author: Robert Lyon <email address hidden>
Date: Thu Jul 24 09:02:40 2014 +1200

User in multi institutions can lose progress bar (Bug #1347362)

If a user is in two (or more) institutions and the first institution has
profile progess set up for it and the other doesn't, the switching of
the select box makes the progress sideblock disappear.

This patch checks that if any institution the user belongs to has
profile progress then display the select box if they belong to two or
more institutions and show either the bar or a message mentioning this
intitution doesn't have progress.

To test:
- user with 1 institution that has progress
- user with 1 institution that has no progress
- user with 2 institution that both have progress
- user with 2 institution where one has progress
- user with 2 institution where none have progress

Change-Id: I4daca26b4b9cfef9faa73be34c34ad931d89465e
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) on 2014-09-09
Changed in mahara:
status: In Progress → Fix Committed

Reviewed: https://reviews.mahara.org/3690
Committed: http://gitorious.org/mahara/mahara/commit/87e031aa43964c818302b888617ad5872001641e
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit 87e031aa43964c818302b888617ad5872001641e
Author: Robert Lyon <email address hidden>
Date: Thu Jul 24 09:02:40 2014 +1200

User in multi institutions can lose progress bar (Bug #1347362)

If a user is in two (or more) institutions and the first institution has
profile progess set up for it and the other doesn't, the switching of
the select box makes the progress sideblock disappear.

This patch checks that if any institution the user belongs to has
profile progress then display the select box if they belong to two or
more institutions and show either the bar or a message mentioning this
intitution doesn't have progress.

To test:
- user with 1 institution that has progress
- user with 1 institution that has no progress
- user with 2 institution that both have progress
- user with 2 institution where one has progress
- user with 2 institution where none have progress

Change-Id: I4daca26b4b9cfef9faa73be34c34ad931d89465e
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments