blockquote displays vertical line

Bug #1346926 reported by Gordon McLeod on 2014-07-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Critical
Robert Lyon

Bug Description

I haven't noticed this before, so presume it's a 1.9.2 issue. When a blockquote is applied to content in a textbox it displays a vertical line (see screenshot). I thought the purpose of a blockquote was to indent the left & right margins eg to display a quote - the display of a grey bar on the left hand looks as if there is a glitch in the content. This seems to be getting pulled from core theme:

blockquote {
    margin: 10px 30px;
    border-left: 2px solid #999999;
    padding-left: 1em;
}

Can this be amended so that the blockquote is invisible - then leave it to the user to format (eg with quotes or italics).

Can anyone also confirm if this issue is present in 1.9.1 stable or if it just affects the beta 1.9.2testing version?
Thanks, Gordon.

Gordon McLeod (g-mcleod1) wrote :
Robert Lyon (robertl-9) wrote :

Hmm, from my tests the use of vertical line has been in the raw theme's style.css file since version 1.7

But anyway there should be an easy way to override a style without having to edit a theme's style or create a new theme.

I'm thinking of adding a hook so one can add in a stylesheet in the /local/ directory.

The way I'll do it is to add a local_add_stylesheet($themename) function hook so that it can be called in /local/lib.php
and it will return a web path to a stylesheet. I'll get the themename passed in so that one can even add a local sheet based on which theme is showing.

Changed in mahara:
status: New → In Progress
importance: Undecided → Wishlist
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 1.10.0
Aaron Wells (u-aaronw) wrote :

I don't think this fix meshes well with the ability to put theme overrides in /local that I added in https://bugs.launchpad.net/mahara/+bug/1328310

Marking "critical" because we should fix or revert this before the 1.10 release.

Changed in mahara:
importance: Wishlist → Critical
Robert Lyon (robertl-9) wrote :

Hmm, by the looks of the code you patch checks for things in:

 local/theme/static/{$filename}

Whereas mine allows for finding a css file by whatever name you want to give it.

In my example in the comments in local lib it shows how you could have a local style.css file for each of the installed themes.

But you theoretically could pass back any path to a css file, which could be useful if a mahara site was part of a larger site and you wanted to include the larger site's css without having to create a new theme.

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3797

Reviewed: https://reviews.mahara.org/3797
Committed: http://gitorious.org/mahara/mahara/commit/20da6bf875a422c992798e0844f4d5807c3015cb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 20da6bf875a422c992798e0844f4d5807c3015cb
Author: Aaron Wells <email address hidden>
Date: Tue Oct 14 11:58:04 2014 +1300

Removing the redundant new local function for style overrides

Bug 1346926: This bug replicates the functionality of the
newly enhanced (in bug 1328310) local/theme directory. I'm
updating the documentation of local/theme at the same time,
to try to avoid this kind of replication in future.

Change-Id: Ia36442ac264f5e0740278592e734ddc0838bb80f

Reviewed: https://reviews.mahara.org/3806
Committed: http://gitorious.org/mahara/mahara/commit/ed34abc79d92f77f19745f29570b3b720f53c862
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit ed34abc79d92f77f19745f29570b3b720f53c862
Author: Aaron Wells <email address hidden>
Date: Tue Oct 14 11:58:04 2014 +1300

Removing the redundant new local function for style overrides

Bug 1346926: This bug replicates the functionality of the
newly enhanced (in bug 1328310) local/theme directory. I'm
updating the documentation of local/theme at the same time,
to try to avoid this kind of replication in future.

Change-Id: Ia36442ac264f5e0740278592e734ddc0838bb80f

Robert Lyon (robertl-9) on 2014-10-15
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers