Tinymce editor can incorrectly appear in profile edit page

Bug #1338394 reported by Nigel Cunningham on 2014-07-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Nigel Cunningham

Bug Description

Mahara version: Master/HEAD
OS: Linux with FF30, Windows Vista with IE 9

The upgrade to TinyMCE 4.0.16 (Bug #1282341) added htdocs/js/tinymce/skins/lightgray/skin.min.css.

This file includes css:

.mce-tinymce {
    position: relative;
    visibility: visible !important;
}

On the profile edit page (http://mahara/artefact/internal/index.php), the only TinyMCE editor in use appears in the first tab, and therefore doesn't normally cause any noticable issue.

If a user tries to add an email address via the second tab and their address fails the validation, the Profile page will reload with the focus being on the second tab. After a brief delay, the TinyMCE editor from the Introduction field on the first tab will appear over the top of the email address fields.

The editor appears because the non-selected tabs don't have the 'collapsed' class added to them at the time the page is loaded. Instead, the safe-hidden class only is applied. The collapsed class is effective in hiding the editor and the safe-hidden class isn't.

I've looked into the git history and Googled the 2 class names, and I couldn't get a clear understanding as to which there are 2 classes. I assume it's somehow related to browser differences, and have therefore provided a simple, minimal patch that ensures both classes are applied to tabs or neither is applied. In my testing on Firefox and IE 9, this addressed the observed bug.

Nigel Cunningham (nigelc-g) wrote :

Reviewed: https://reviews.mahara.org/3481
Committed: http://gitorious.org/mahara/mahara/commit/c34857eec2e3e53343cf0078627b95e78a0b42c1
Submitter: Yuliya Bozhko (<email address hidden>)
Branch: master

commit c34857eec2e3e53343cf0078627b95e78a0b42c1
Author: Nigel Cunningham <email address hidden>
Date: Mon Jul 7 11:30:46 2014 +1000

(Bug 1338394) Profile TinyMCE visibility issue

This patch addresses an issue wherein TinyMCE will incorrectly
appear on the profile edit page if a user enters a new email
address that fails validation.

Change-Id: I4197062276e2227d9003599249189c5dcb06e632
Signed-off-by: Nigel Cunningham <email address hidden>

Changed in mahara:
status: New → Fix Committed
Changed in mahara:
importance: Undecided → Medium
assignee: nobody → Nigel Cunningham (nigelc-g)
milestone: none → 1.10.0
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers