Tinymce editor can incorrectly appear in profile edit page
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Nigel Cunningham |
Bug Description
Mahara version: Master/HEAD
OS: Linux with FF30, Windows Vista with IE 9
The upgrade to TinyMCE 4.0.16 (Bug #1282341) added htdocs/
This file includes css:
.mce-tinymce {
position: relative;
visibility: visible !important;
}
On the profile edit page (http://
If a user tries to add an email address via the second tab and their address fails the validation, the Profile page will reload with the focus being on the second tab. After a brief delay, the TinyMCE editor from the Introduction field on the first tab will appear over the top of the email address fields.
The editor appears because the non-selected tabs don't have the 'collapsed' class added to them at the time the page is loaded. Instead, the safe-hidden class only is applied. The collapsed class is effective in hiding the editor and the safe-hidden class isn't.
I've looked into the git history and Googled the 2 class names, and I couldn't get a clear understanding as to which there are 2 classes. I assume it's somehow related to browser differences, and have therefore provided a simple, minimal patch that ensures both classes are applied to tabs or neither is applied. In my testing on Firefox and IE 9, this addressed the observed bug.
Changed in mahara: | |
status: | New → Fix Committed |
Changed in mahara: | |
importance: | Undecided → Medium |
assignee: | nobody → Nigel Cunningham (nigelc-g) |
milestone: | none → 1.10.0 |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/3481