Why don't plugin theme directories have a "template" subdirectory?

Bug #1328319 reported by Aaron Wells on 2014-06-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Aaron Wells

Bug Description

In working on Bug 1231755, I realized that plugin theme directories don't have separate "static" and "templates" subdirectories like core theme directories. They do have a "static" subdirectory, but the templates just sit loose inside the theme directory.

Expected: /blocktype/creativecommons/theme/raw/templates/statement.tpl
Actual: /blocktype/creativecommons/theme/raw/statement.tpl

Since we're going to be making the plugin theme directories less prominent via Bug 1231755, we should make their behavior less irregular so that when it is used, it's easy to figure out. Which means that we should add a "templates" directory first in the search path.

In order to support older plugins that don't have a "templates" directory, though, we should continue to look for them loose in the theme directory as well.

Reviewed: https://reviews.mahara.org/3426
Committed: http://gitorious.org/mahara/mahara/commit/aada15e779b68f0bbd58c298a97405d31bf77c7d
Submitter: Yuliya Bozhko (<email address hidden>)
Branch: master

commit aada15e779b68f0bbd58c298a97405d31bf77c7d
Author: Aaron Wells <email address hidden>
Date: Tue Jun 10 12:25:10 2014 +1200

Expect plugin theme directories to have a "templates" subdirectory

Bug 1328319. Still keeping the old location in the search path as well,
for backwards-compatibility.

Change-Id: Iee2c908bad933a3942f103df6f827ace3beee259

Changed in mahara:
status: New → Fix Committed
tags: added: nominatedfeature
Changed in mahara:
importance: Undecided → Medium
assignee: nobody → Aaron Wells (u-aaronw)
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers