Editing a page can be frozen if its content has ".row" element

Bug #1327920 reported by Son Nguyen on 2014-06-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Son Nguyen
1.8
High
Son Nguyen
1.9
High
Son Nguyen

Bug Description

Version: master(1.10), 1.9.1, and 1.8.3

If a page content has ".row" elements like <div class=".row"> or <table class="row">, it will cause the function checkColumnButtonDisabledState() died.

Error:
TypeError: Cannot call method 'match' of undefined

Reviewed: https://reviews.mahara.org/3418
Committed: http://gitorious.org/mahara/mahara/commit/599929fb0b3ed771b3d68b540a34cf0157ec2222
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 599929fb0b3ed771b3d68b540a34cf0157ec2222
Author: Son Nguyen <email address hidden>
Date: Mon Jun 9 14:19:00 2014 +1200

Correct the selector of rows of a page when editing (Bug 1327920)

Change-Id: I8ed56c07ed516555da22547484ae0a7e3ff274da
Signed-off-by: Son Nguyen <email address hidden>

Robert Lyon (robertl-9) on 2014-06-09
Changed in mahara:
status: Confirmed → Fix Committed
Mahara Bot (dev-mahara) wrote :

Patch for "1.8_STABLE" branch: https://reviews.mahara.org/3421

Reviewed: https://reviews.mahara.org/3420
Committed: http://gitorious.org/mahara/mahara/commit/a64a5ed202df9ee538b7dee50e931a89bda2043f
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit a64a5ed202df9ee538b7dee50e931a89bda2043f
Author: Son Nguyen <email address hidden>
Date: Mon Jun 9 14:19:00 2014 +1200

Correct the selector of rows of a page when editing (Bug 1327920)

Change-Id: I8ed56c07ed516555da22547484ae0a7e3ff274da
Signed-off-by: Son Nguyen <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3421
Committed: http://gitorious.org/mahara/mahara/commit/89d355d94ec5c1e7983721697e52fe85e0ca7ec2
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.8_STABLE

commit 89d355d94ec5c1e7983721697e52fe85e0ca7ec2
Author: Son Nguyen <email address hidden>
Date: Mon Jun 9 14:19:00 2014 +1200

Correct the selector of rows of a page when editing (Bug 1327920)

Change-Id: I8ed56c07ed516555da22547484ae0a7e3ff274da
Signed-off-by: Son Nguyen <email address hidden>

Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers