Eliminate Mochikit from mahara.js

Bug #1323920 reported by Aaron Wells on 2014-05-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned

Bug Description

Mahara currently includes MochiKit and JQuery. Annoyingly, they both use the $() function quite a bit, and this inevitably causes us problems.

Mochkit is old, and everything it does can also be done by jQuery, so we should try to refactor it away to save us future development headaches.

Aaron Wells (u-aaronw) on 2014-05-28
summary: - Wishlist: Eliminate Mochikit
+ Eliminate Mochikit
Son Nguyen (ngson2000) on 2014-08-07
Changed in mahara:
assignee: nobody → Son Nguyen (ngson2000)
Son Nguyen (ngson2000) on 2014-08-11
Changed in mahara:
milestone: 1.10.0 → 1.11.0
Son Nguyen (ngson2000) on 2014-08-25
Changed in mahara:
status: Confirmed → In Progress
Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
milestone: 15.04.0 → 15.04.1

This will have to wait until after the Bootstrap reskinning is merged in.

Changed in mahara:
milestone: 15.04.1 → 15.10.0
Changed in mahara:
assignee: Son Nguyen (ngson2000) → nobody
milestone: 15.10.0 → none
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5618

Hi Robert been looking at this in Windows 8 IE10 and the welcome page has lost some icons and fonts are looking different in comparison with Chromium and Firefox. Please see the attached screen shot.

Also on the admin user's journal screen the notebook icon is missing in IE10. Please see the attachment.

Hey Robert when I am on the interests screen for 'Resume' I see this warning: [WAR] 27 (lib/web.php:2184) Undefined index: title
across all browsers I think you saw this when I called you over it keeps popping up so I am logging it.

Please seethe attached screen shot.

Hi Robert also all the options under Resume --> Goals and skills are missing their description fields in Windows 8. Please see the attached screen shot

Also 'Field' for introduction when on this page 'About me' is missing as well. please see the attached screen shot.

Hello again Robert also when uploading users by csv in IE I don't see the loading icon. Please see the attached screen cast.

Aaron Wells (u-aaronw) wrote :

Testing the patch https://reviews.mahara.org/#/c/5618/ I was able to replicate the issue with the Resume Interests page that Charlie described here: https://bugs.launchpad.net/mahara/+bug/1323920/comments/6

But rebasing the patch resolved that issue, so I think it was an unrelated bug.

Reviewed: https://reviews.mahara.org/5618
Committed: https://git.mahara.org/mahara/mahara/commit/a4dc90b3dfea2aa860cabe8da30b12f505ea2376
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit a4dc90b3dfea2aa860cabe8da30b12f505ea2376
Author: Jono Mingard <email address hidden>
Date: Fri Oct 23 16:50:04 2015 +1300

Remove unused and superfluous JavaScript (Bug #1323920)

Some of these files aren't loaded on any pages, some (ie. debug.js)
are no longer necessary with modern debugging tools, and some have
been replaced by Bootstrap functionality

behatnotneeded: should be functionally identical

Change-Id: I6d1b3874de5d42ccc00a8c0d2bb0e8bc162747d4

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5923

Reviewed: https://reviews.mahara.org/5542
Committed: https://git.mahara.org/mahara/mahara/commit/174ca581f6ec8f93527b67c09dcda6be6cda76db
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 174ca581f6ec8f93527b67c09dcda6be6cda76db
Author: Jono Mingard <email address hidden>
Date: Thu Oct 15 14:23:40 2015 +1300

Purge MochiKit from mahara.js (Bug #1323920)

Replace all MochiKit function calls with either jQuery or rewritten
versions. Also remove some old functions which aren't needed or
weren't being used

behatnotneeded: should be functionally identical

Change-Id: Ie48032009b14adddfecbe8c381f4ff692afafe70

Changed in mahara:
milestone: none → 16.10.0
status: In Progress → Fix Committed
summary: - Eliminate Mochikit
+ Eliminate Mochikit from mahara.js
Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
status: Fix Committed → Fix Released
tags: added: nominatedfeature
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers