Don't let locked views be added to collections

Bug #1323163 reported by Aaron Wells on 2014-05-26
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Aaron Wells

Bug Description

Currently, you can add a locked (submitted) page to a collection. You shouldn't be able to do this, because a locked page should not be editable, and because it makes it possible to create a collection that awkwardly contains a mix of submitted and unsubmitted pages.

To replicate:

1. Create a page A
2. Create a group G that allows submissions
3. Submit page A to group G
4. Create a collection C
5. Add page A to collection C.

Expected result: Page A should not show up as available to add to the collection
Actual result: Page A does show up as available to add to the collection

Aaron Wells (u-aaronw) wrote :

So, a related question here, is whether we should make it impossible to remove an individually-submitted page from a collection. I think it's probably best to continue to allow this, because it's the only way to convert a semi-locked collection into an unlocked collection.

On the other hand, the downside of allowing this is that it leads to a confusing user experience. Like, if a user removes a locked page from a collection, they'll expect that page to move from the list of pages in the collection, to the list of available pages. Instead, it will simply disappear from the page.

Aaron Wells (u-aaronw) on 2014-09-10
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers