Can't stop masquerading as user if they have a profile field required

[Robert Lyon]

To test:

1) Log into a site, that contains a bunch of users, as a site admin.
2) Set a profile field as compulsory (in Extensions -> artefact -> profile configuration form) - pick one you know the users haven't filled in before.
3) Navigate away from page and you are prompted to fill in detail (if you don't have it filled in)
4) Now try to masquerade as a user - you should see the 'Required profile fields' form to allow you to update the user.
5) But you decide you don't want to fill in the info - maybe you don't know it - so you click the 'Become Administrator again' link at top of page.

Problem:

But instead of stopping the masquerading it keeps wanting you to fill in the info for the user.

Issue:
Need to ignore the checking of required fields when exiting masquerading

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/3375

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/3375
Committed: http://gitorious.org/mahara/mahara/commit/9c0ac80178045691050d7c71f94c3933e1f1c170
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 9c0ac80178045691050d7c71f94c3933e1f1c170
Author: Robert Lyon <email address hidden>
Date: Wed May 21 12:31:55 2014 +1200

Allow masqueraders to exit from user when required fields needed

Bug 1321499
Signed-off-by: Robert Lyon <email address hidden>

Change-Id: I3fa5a12a75321996ea3eac934d891a34bef14b8f