Change jQuery rating to new Bootstrap star ratings

Bug #1316917 reported by Aaron Wells
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

We're currently on version 3.14. The latest is 4.11. https://code.google.com/p/jquery-star-rating-plugin/

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3329

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3328

Revision history for this message
Steven (stevens-q) wrote : Re: Update jquery.rating.js to 4.11

=== Prerequisites ===
1. User is logged in
2. install code patch from https://reviews.mahara.org/#/c/3329

=== How to test ===
1. Place comments on a page and select a star rating
2. confirm that the comment and star rating is displayed on the published page ✔
3. return back to the page and make another comment and star rating
4. confirm that the comment and star rating is displayed on the published page for the new comment ✔
5. confirm that other users plus the owner can make comments and star ratings for other artefacts as follows
--- a) image artefacts ✔
--- b) text box (when enabled by owner) ✔
--- c) media artefacts ✔
--- d) profile pages ✔

=== Bug ===

Placing a second feedback comment and star rating causes the previous star rating to disappear(not the comment). Upon refreshing the page, the previous star ratings will reappear.

Catalyst QA Failed Testing ✘

Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.10.0 → 1.11.0
Revision history for this message
Aaron Wells (u-aaronw) wrote :

We didn't get this in to 1.10.0, but version 4.11 is still the latest version, so the patch is still valid. I'll see about addressing the problems found.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Now that we've upgraded the jQuery version in Mahara 1.10.0, the star rating has stopped working entirely. (See bug 1394019 ) My patch to upgrade it causes it work again. So we'll need to backport this to Mahara 1.10.0 as well.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Actually it turns out I had the wrong commit checked out. This still breaks in Mahara 15.04dev even after applying the upgrade.

To replicate:

1. Turn on comment star ratings (on the comment artefact's config page)

2. Place a comment on a page, and give the comment a star rating. Click submit.

Expected result: You should see your star rating under the comment.

Actual result: You do not see your star rating under the comment.

Interestingly, it works when I tested it using a Selenium script, but not when I do it manually. Definitely something weird going on there...

Aaron Wells (u-aaronw)
no longer affects: mahara/1.10
Aaron Wells (u-aaronw)
no longer affects: mahara/1.10
no longer affects: mahara/15.04
Changed in mahara:
milestone: 15.04.1 → 15.10.0
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 15.10.0 → 16.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6048

Revision history for this message
Robert Lyon (robertl-9) wrote : Re: Update jquery.rating.js to 4.11

I've tried adding a simple ratings system based on using bootstrap glyphs

summary: - Update jquery.rating.js to 4.11
+ Change jQuery rating to new Bootstrap star ratings
Changed in mahara:
assignee: Aaron Wells (u-aaronw) → nobody
assignee: nobody → Robert Lyon (robertl-9)
tags: added: nominatedfeature
removed: externallibraries
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6048
Committed: https://git.mahara.org/mahara/mahara/commit/d1bf622af03b2ebb2a0e67bbdc7c09f92d2febbb
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit d1bf622af03b2ebb2a0e67bbdc7c09f92d2febbb
Author: Robert Lyon <email address hidden>
Date: Thu Feb 11 11:29:49 2016 +1300

Bug 1316917: New approach to star rating using bootstrap glyphs

This is a slimmer / stripped down system for doing jquery ratings.

Instead of relying on styling radio buttons it relies on bootstrap
glyphs and a hidden input field.

The code is also controlled by a pieform element

See lib/form/elements/ratings.php for more info about that part

It also has some new settings in the Extensions -> artefact -> comment
config form. They include settign the colour for the star icon, or
using a different icon, eg hearts/thumbs up, and the number of ratings
to show (3 - 12)

behatnotneeded

Change-Id: Ibf529efcb9a665c9f303242ed12d0c7b3dee2356
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6299

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6299
Committed: https://git.mahara.org/mahara/mahara/commit/c0244b6d6917158659f3ea336098cc8c3b2193b4
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit c0244b6d6917158659f3ea336098cc8c3b2193b4
Author: Robert Lyon <email address hidden>
Date: Thu Feb 11 11:29:49 2016 +1300

Bug 1316917: New approach to star rating using bootstrap glyphs

This is a slimmer / stripped down system for doing jquery ratings.

Instead of relying on styling radio buttons it relies on bootstrap
glyphs and a hidden input field.

The code is also controlled by a pieform element

See lib/form/elements/ratings.php for more info about that part

It also has some new settings in the Extensions -> artefact -> comment
config form. They include settign the colour for the star icon, or
using a different icon, eg hearts/thumbs up, and the number of ratings
to show (3 - 12)

behatnotneeded

Change-Id: Ibf529efcb9a665c9f303242ed12d0c7b3dee2356
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d1bf622af03b2ebb2a0e67bbdc7c09f92d2febbb)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6316

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.