Progress completion bar giving errors

Bug #1314460 reported by Robert Lyon on 2014-04-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.10
High
Robert Lyon
1.9
High
Robert Lyon

Bug Description

[WAR] bf (lib/mahara.php:2970) Array to string conversion
Call stack (most recent first):

    log_message("Array to string conversion", 8, true, true, "/home/kristina/code/19stable/htdocs/lib/mahara.php", 2970) at /home/kristina/code/19stable/htdocs/lib/errors.php:433
    error(8, "Array to string conversion", "/home/kristina/code/19stable/htdocs/lib/mahara.php", 2970, array(size 19)) at Unknown:0
    array_diff(array(size 3), array(size 0)) at /home/kristina/code/19stable/htdocs/lib/mahara.php:2970
    progressbar_sideblock(true) at /home/kristina/code/19stable/htdocs/lib/web.php:635
    smarty() at /home/kristina/code/19stable/htdocs/admin/users/progressbar.php:228

Robert Lyon (robertl-9) wrote :

A problem I found was the array_diff() was trying to check a multi-dimensional array against an array.

According to php.net "This function only checks one dimension of a n-dimensional array. "

So I'll fix that up first.

Changed in mahara:
importance: Undecided → High
milestone: none → 1.10.0

Reviewed: https://reviews.mahara.org/3302
Committed: http://gitorious.org/mahara/mahara/commit/6ca2821affe8eccbeda5ee0b27f087e4c72423ad
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6ca2821affe8eccbeda5ee0b27f087e4c72423ad
Author: Aaron Wells <email address hidden>
Date: Wed Apr 30 15:56:21 2014 +1200

Removing unnecessary array_diff

Bug 1314460: No need to remove $locked from $progressbaritems, because the
list of progressbaritems is limited by the $onlytheseplugins array, and that
has already had $locked removed from it.

Change-Id: Ie8418703d0333eaf2ef2ba8301ec235e4dcddd03

Reviewed: https://reviews.mahara.org/3309
Committed: http://gitorious.org/mahara/mahara/commit/718602a06560a21b0a6ebbcb5bcf54addb6ed67e
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit 718602a06560a21b0a6ebbcb5bcf54addb6ed67e
Author: Aaron Wells <email address hidden>
Date: Wed Apr 30 15:56:21 2014 +1200

Removing unnecessary array_diff

Bug 1314460: No need to remove $locked from $progressbaritems, because the
list of progressbaritems is limited by the $onlytheseplugins array, and that
has already had $locked removed from it.

Change-Id: Ie8418703d0333eaf2ef2ba8301ec235e4dcddd03

Aaron Wells (u-aaronw) on 2014-10-20
Changed in mahara:
milestone: 1.10.0 → none
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers