Error message when admin adds user to institution and quota is full

Bug #1311458 reported by Kristina Hoeppner on 2014-04-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon

Bug Description

Bug #1204699 sends a notification to site and institution admins when a user tries to register for an institution whose quota has been reached.

However, the system (Mahara 1.9) still gives an error message only in the error log when an admin tries to add a user to an institution with a full quota. When you don't have error logging to the screen turned on, you only get "Site not available". There should be a proper error message.

Currently, I get:

[WAR] be (lib/institution.php:285) Trying to add a user to an institution that already has a full quota of members
Call stack (most recent first):

    Institution->addUserAsMember(object(User)) at /home/kristina/code/19stable/htdocs/auth/user.php:705
    User->join_institution("careerservice") at /home/kristina/code/19stable/htdocs/admin/users/edit.php:793
    edituser_institution_submit(object(Pieform), array(size 8)) at Unknown:0
    call_user_func_array("edituser_institution_submit", array(size 2)) at /home/kristina/code/19stable/htdocs/lib/pieforms/pieform.php:527
    Pieform->__construct(array(size 5)) at /home/kristina/code/19stable/htdocs/lib/pieforms/pieform.php:162
    Pieform::process(array(size 5)) at /home/kristina/code/19stable/htdocs/lib/pieforms/pieform.php:71
    pieform(array(size 5)) at /home/kristina/code/19stable/htdocs/admin/users/edit.php:733

Testing was done on Mahara 1.9.0, an upgraded Mahara 1.8 site

Robert Lyon (robertl-9) on 2014-04-23
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
status: New → In Progress

Reviewed: https://reviews.mahara.org/3282
Committed: http://gitorious.org/mahara/mahara/commit/cf73073a0c4bc5405da5a2a5c2ddd542b2aa1723
Submitter: Ghada El-Zoghbi (<email address hidden>)
Branch: master

commit cf73073a0c4bc5405da5a2a5c2ddd542b2aa1723
Author: Robert Lyon <email address hidden>
Date: Thu Apr 24 10:41:30 2014 +1200

Fixing warning messages for institution full (Bug #1311458)

1) When adding a user via admin/users/edit.php page
2) When self-registering

Also got places where we check institution isFull() to send out an
email to the institution admins to alert them of this problem.

Change-Id: I70a1025651a6e093c51e99bbcbce781c72d7f890
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers