Content editor sidebar doesn't work on Chrome

Bug #1305451 reported by Olli Puurunen on 2014-04-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Son Nguyen
1.9
High
Robert Lyon

Bug Description

Adding content by clicking an item from the sidebar fails on Chrome.

Steps to repeat:

1. Create a new page
2. Go to Edit content -tab
3. Click on Text box

Expected result:

"Add block: Text box" -popup appears.

Actual result:

Nothing happens.

In file js/views.js, in function ViewManager.makeNewBlocksDraggable the event handler of the .blocktypelink -elements is assumed that event.buttons -property exists and that it is a number. However, as you can see from https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent.buttons#Browser_compatibility, Chrome doesn't seem to support the property.

Mahara version: Latest from git (1.9rc2dev)
Browser: Chrome (Linux) 33.0.1750.152

Aaron Wells (u-aaronw) on 2014-04-10
Changed in mahara:
milestone: none → 1.9.0
importance: Undecided → High
status: New → Triaged
tags: added: regression
Son Nguyen (ngson2000) on 2014-04-10
Changed in mahara:
assignee: nobody → Son Nguyen (ngson2000)
status: Triaged → In Progress

Reviewed: https://reviews.mahara.org/3229
Committed: http://gitorious.org/mahara/mahara/commit/0d747a8f174c2db36ae9d2ca45d89af44b554433
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0d747a8f174c2db36ae9d2ca45d89af44b554433
Author: Son Nguyen <email address hidden>
Date: Fri Apr 11 11:56:03 2014 +1200

Make sure the pop-up 'Add block' called once when click
Bug 1305451 and 1305481

MouseEvent.buttons is not defined in Chrome, use button insteads

Change-Id: Icf51e74ba64893925061e35e601fa40b4f761650
Signed-off-by: Son Nguyen <email address hidden>

Robert Lyon (robertl-9) on 2014-04-11
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
milestone: 1.9.0 → 1.10.0

Reviewed: https://reviews.mahara.org/3272
Committed: http://gitorious.org/mahara/mahara/commit/1acaa689b01fe1964204b79273f856a14727edb1
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit 1acaa689b01fe1964204b79273f856a14727edb1
Author: Son Nguyen <email address hidden>
Date: Fri Apr 11 11:56:03 2014 +1200

Make sure the pop-up 'Add block' called once when click
Bug 1305451 and 1305481

MouseEvent.buttons is not defined in Chrome, use button insteads

Change-Id: Icf51e74ba64893925061e35e601fa40b4f761650
Signed-off-by: Son Nguyen <email address hidden>

Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers