Update the Mahara-Moodle assignment plugin to work with the Moodle 2.3+ assignment module

Bug #1303491 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Aaron Wells

Bug Description

This is a bug to track the update to the Mahara assignment plugin type for Moodle.

Tags: mnet moodle
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/3200

Revision history for this message
Aaron Wells (u-aaronw) wrote :

The updated Moodle plugin requires a patch to Moodle core to add a hook for mod/assign/submission plugins to be able to respond when an assignment submission is "reopened" for another attempt: https://tracker.moodle.org/browse/MDL-44971

summary: - Update the Mahara-Moodle assignment plugin to work with the Moodle 2.2+
+ Update the Mahara-Moodle assignment plugin to work with the Moodle 2.3+
assignment module
Revision history for this message
Aaron Wells (u-aaronw) wrote :

With funding from BCU, I've expanded the plugin to handle collections as well as views. That's what gerrit patch 3200 is for.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Or, to clarify, gerrit patch 3200 represents expansions to the Mahara web services API, which allow it to be used to view and submit collections instead of just single views.

I'd like to try to get this into 1.9.0, but if that proves not to be possible, the code change at least rebases cleanly onto 1.9_STABLE and 1.8_STABLE (I haven't tried any earlier versions)

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Pushing this out to 1.10

Changed in mahara:
milestone: 1.9.0 → 1.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3239

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Test instructions:

Okay, the tricky thing here is that there are multiple versions of the Moodle-Mahara assignment submission plugin, and this patch should be backwards compatible with all of them. I've run tests to make sure it works in these combinations:

1. Moodle 2.6 + Portland U plugin: https://github.com/fellowapeman/moodle-assign_mahara
1a. To run the Portland U plugin you must also install a local plugin: https://github.com/fellowapeman/moodle-local_mahara

2. Moodle 2.3 + the Moodle 2.3 version of our fork of the plugin: https://github.com/catalyst/moodle-assignsubmission-mahara/tree/moodle23

3. Moodle 2.6 + the Moodle 2.6 version of our fork of the plugin: https://github.com/catalyst/moodle-assignsubmission-mahara/tree/moodle26

How to test:

1. Install the Moodle site & the Mahara site.

2. Set up Mnet between them (see instructions here: https://wiki.mahara.org/index.php/User:Aaronw/Quick_Mnet_setup )

2. Set up a course in Moodle with an "assignment" activity using the Mahara submission method. Also put a "Network Servers" block in that course.

3. Log in as a student enrolled in that course. Go to the course and click on the link to Mahara via the "Network Servers" block.

4. Create some pages and collections in Mahara.

5. Go back to Moodle (still as the student) and create your submission for the assignment activity.

Expected result: If you're using the Portland U plugin or the Moodle 2.3 version of the Catalyst plugin, you should see a list of the student's views available. If you're using the Moodle 2.6 version of the Catalyst plugin, you should also see collections.

6. Add a view or collection to your assignment. Submit the assignment.

Expected result: The submitted view or assignment should now be locked in Mahara. (Unless you're using the Portland U plugin, and have disabled page locking)

7. Log out of the student, and log back into Moodle as a teacher. Go back to the course and look at the gradebook for the assignment.

Expected result: You should see a link to the selected view/collection, and you should be able to click it and see the view/collection in Mahara

Revision history for this message
Ghada El-Zoghbi (ghada-z) wrote :

Hi Aaron,

Thanks for the test instructions. Does that mean we don't need to worry about the 'moodle26-merged' branch?

Thanks.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

I think we talked about this on IRC a few days ago, but just for the record, at the moment moodle26-merged is my work-in-progress attempt at merging the Portland U and Lancaster U versions of the plugin. So... if we wanted to be super-thorough we could test against it as well, but if it works in the other branches it'll probably work on that one as well.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3239
Committed: http://gitorious.org/mahara/mahara/commit/7858d6f904ef95d6bce9fe518447e1ea26d49406
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7858d6f904ef95d6bce9fe518447e1ea26d49406
Author: Aaron Wells <email address hidden>
Date: Tue Nov 5 14:38:46 2013 +1300

Let web services handle collections as well as views

Bug 1303491: These web services are used by the Moodle-Mahara
assignment plugin. We're expanding it to handle collections
properly.

Change-Id: I9c2ffd7a2d65f6b5645ae3005c5993315b43d451

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.