Saving a customised color in a skin does not work

Bug #1298717 reported by Son Nguyen on 2014-03-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon

Bug Description

Version: master 1.9
Platform: all
Browser: FF, Chrome, ipad, android tablet

In Profolio/Skins page, click edit a skin, changed the colour then clicked save. However,
saving a customised color in a skin did not work

Robert Lyon (robertl-9) wrote :
Changed in mahara:
status: New → In Progress
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 1.9.0

Reviewed: https://reviews.mahara.org/3138
Committed: http://gitorious.org/mahara/mahara/commit/862953ea0bcd124268ee8a525f65da1d332f585d
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 862953ea0bcd124268ee8a525f65da1d332f585d
Author: Robert Lyon <email address hidden>
Date: Mon Mar 31 12:23:49 2014 +1300

Skin colour options not resaving (Bug #1298717)

Was setting them as transparent if the colour checkbox was checked on
resave

Change-Id: Iac798c7881a053497944d4179d56c0ade9f66444
Signed-off-by: Robert Lyon <email address hidden>

Steven (stevens-q) wrote :

== Prerequisites ==
you must have skins configuration set in your config.php file $cfg->skins = true;
==================================================================================

=== How to test - (Managing Skins) changing a skin colour ===
1. browse to you portfolio tab in Mahara
2. click on the skins link in the sub menu
3. Create, edit or import a skin
4. change a few of the colours to something unique and save the skin
5. confirm that the changes you made have been updated and saved
6. click the pages link in the sub menu under the portfolio tab
7. create or edit a page
8. click the choose skin button and select a skin from either the my skins or the public skins
9. click save
10. confirm that the page now uses the colours outlined in the skins

=== Test Results - (Managing Skins) changing a skin colour ===
5. confirmed that the changes you made have been updated and saved ✔
10. confirmed that the page now uses the colours outlined in the skins ✔
==================================================================================

=== How to Test - skins previews ===
1. browse to you portfolio tab in Mahara
2. click on the skins link in the sub menu
3. confirm that existing public skins only show
 a. skin name
 b. a star icon (add to favourites)
 c. an information icon
 d. a colour image
4. confirm that any skins that you have created, public or private display the following:
 a. Name for skin
 b. edit icon
 c. information icon
 d. export icon
 e. a delete icon
 f. coloured image using colours selected in the skin

=== Test Results - skins previews ===
3. confirmed that existing public skins only show
 a. skin name ✔
 b. a star icon (add to favourites) ✔
 c. an information icon ✔
 d. a colour image ✔
4. confirmed that any skins that you have created, public or private display the following:
 a. Name for skin ✔
 b. edit icon ✔
 c. information icon ✔
 d. export icon ✔
 e. a delete icon ✔
 f. coloured image using colours selected in the skin ✔

Catalyst QA Approved ✔

Robert Lyon (robertl-9) on 2014-04-02
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers