Add artefact-level sharing

Bug #1298646 reported by Yuliya Bozhko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
In Progress
Wishlist
Aaron Wells

Bug Description

As was described during MaharaHui 2014, this is an improvement we would like to add to Mahara.

Full specs are here https://mahara.org/view/artefact.php?artefact=363268&view=1088

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3260

Revision history for this message
Robert Lyon (robertl-9) wrote :

Hi Yuliya,

Looking at: http://www.jqueryrain.com/2012/03/35-best-ajax-jquery-autocomplete-tutorial-plugin-with-examples/

There seems to be a wide range of options to choose from so my question is:
 Is tokininput.js the best one for the job?

What are the features that are needed/required for an auto complete? and which ones on that list would meet the requirements and therefore which would be the best for mahara?

It might be worth discussing with the community what a list of requirements for an auto complete would be.

Bob

Revision history for this message
Yuliya Bozhko (yuliya.bozhko) wrote :

Hi Robert,

I added this element to use it later in artefact sharing field when user can start typing in other users/groups names and they will be given suggestions to select. I have given it some thought, looked through a number of available libraries, and selected this one for a number of reason:

- Code updates (how recent/maintained is the library)
- Ease of use
- Support for script to handle search requests
- Customisable default strings (for hint, searching progress, no results)
- Add new items if no results found
- Custom theme support
- Ability to pre-populate fields
- Ability to format results
- Ability to prevent duplicates

I guess I wouldn't mind discussing this with the dev team rather than community if you think it is necessary. Do you have any other library in mind that you would recommend?

Yuliya

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3264

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3264
Committed: http://gitorious.org/mahara/mahara/commit/2df0d557c1dd4fe6bd99ca379782e992ab4e3a84
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2df0d557c1dd4fe6bd99ca379782e992ab4e3a84
Author: Yuliya Bozhko <email address hidden>
Date: Tue Apr 15 17:31:25 2014 +1200

Move objectionable forms from view library (Bug #1298646)

So that we can later use them separately for artefact level access,
and report artefacts separately from pages.

When testing, everything should work as it worked before with
reporting objectionable material.

Also fixed "Creating default object from empty value" error
when ActivityTypeObjectionable object is constructed.

Change-Id: I6d95a5546b2425d9b522435da26902e420139d84
Signed-off-by: Yuliya Bozhko <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3288

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3316

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3288
Committed: http://gitorious.org/mahara/mahara/commit/3ba72d71f6243ff9cba51d9c3b1888d5ed56df55
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3ba72d71f6243ff9cba51d9c3b1888d5ed56df55
Author: Yuliya Bozhko <email address hidden>
Date: Thu Apr 24 10:43:41 2014 +1200

Some artefact refactoring (Bug #1298646)

Fixes in this patch:

- Moved artefact.php to artefacts directory to separate it from pages.
- Fixed reference to a wrong 'artefactonlyviewableinview' string.
- Removed add_to_render_path() and its calls which have no purpose at all.
- Removed 'artefact_parent_cache' table.
- Removed cron jobs related to 'artefact_parent_cache' from DB.
- Added 'path' column in 'artefact' table to easier calculate hierarchy.
- Added ArtefactTest.php for artefacts unit tests

Change-Id: Ia14cd85b94c32a950354446ee3565bd2964c625c
Signed-off-by: Yuliya Bozhko <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3337

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Spinning off autocomplete pieform element into a separate bug: https://bugs.launchpad.net/mahara/+bug/1323921

Revision history for this message
Yuliya Bozhko (yuliya.bozhko) wrote :

Instructions for the patch https://reviews.mahara.org/#/c/3337/

Before checking out the patch:
1. Make sure that you have a page with some artefacts.
2. As any user: report a page and/or artefact as objectionable.

To test:
- Check out the patch.
- Run upgrade.
- Make sure that things that were reported as objectionable are still reported as such (page, artefact). NOTE: forums objectionable data is not migrated as it is a new feature that hasn't been released yet.
- As admin try to: mark things as not objectionable and/or delete objectionable things.
- As any user: try to create new objectionable reports for forums, pages, artefacts, and make sure that there are no issues.
- Overall make sure that everything works as before.

Revision history for this message
Steven (stevens-q) wrote :

Before checking out the patch:
-----------------------------------------------------
[✔] 1. Make sure that you have a page with some artefacts.
[✔] 2. As any user: report a page and/or artefact as objectionable.

To test:
------------------
[✔] Check out the patch.
[✔] Run upgrade.
[✔] Make sure that things that were reported as objectionable are still reported as such (page, artefact).
NOTE: forums objectionable data is not migrated as it is a new feature that hasn't been released yet.
[✔] As admin try to: mark things as not objectionable and/or delete objectionable things.
[✔] As any user: try to create new objectionable reports for
[✔] forums,
[✔] pages,
[✔] artefacts,
and make sure that there are no issues.
[✔] Overall make sure that everything works as before.

everything appears to be working fine

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3337
Committed: http://gitorious.org/mahara/mahara/commit/bbca7a55ddabd1519f3093892f63a9ac4607ef78
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit bbca7a55ddabd1519f3093892f63a9ac4607ef78
Author: Yuliya Bozhko <email address hidden>
Date: Fri May 9 12:24:55 2014 +1200

Refactor the way objectionable items are stored (Bug #1298646)

- Created 'objectionable' table
- Migrated existing objectionable records to a new table
- Added is_objectionable() method to View class
- Fixed can_view_view() and elasticsearch to use new table
- Fixed artefact.tpl style to match view page when displaying "Not objectionable" form
- Make forum reports use new 'objectionable' table

Change-Id: Ib3759e86c4003216ad57f3cf68911b13e50e9c67
Signed-off-by: Yuliya Bozhko <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3410

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3410
Committed: http://gitorious.org/mahara/mahara/commit/c679c3b2ceef2ceba2c3181cca4cfcd5ada0daa9
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit c679c3b2ceef2ceba2c3181cca4cfcd5ada0daa9
Author: Aaron Wells <email address hidden>
Date: Thu Jun 5 16:11:31 2014 +1200

Fixing bugs in the objectionable items refactor

Bug 1298646: No point in adding columns to the interaction_forum_post table
just to immediately drop them again.

Also, there were some lingering "accesstype IS NULL" checks in the elasticsearch
access queries, which should have been removed along with the "accesstype != objectionable"
that they were previously parenthetical with.

And, the artefact_access table doesn't need to accept "objectionable" as
an accesstype enum value anymore.

Change-Id: I961f15e98eb8aab95e4e5b16af223eb61588f671
Signed-off-by: Yuliya Bozhko <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3446

Aaron Wells (u-aaronw)
Changed in mahara:
assignee: Yuliya Bozhko (yuliya.bozhko) → nobody
assignee: nobody → Aaron Wells (u-aaronw)
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/3834

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3834
Committed: http://gitorious.org/mahara/mahara/commit/c7a5034451a72fb182b988014f1205d68d404a8f
Submitter: Son Nguyen (<email address hidden>)
Branch: 1.10_STABLE

commit c7a5034451a72fb182b988014f1205d68d404a8f
Author: Aaron Wells <email address hidden>
Date: Mon Oct 20 09:44:50 2014 +1300

Marking a page objectionable caused it to be hidden

Bug 1298646: Objectionable pages are meant to remain visible
to users until an admin comes along and deletes them. They were
accidentally being hidden due to a bug in the logic flow in
can_view_view()

Change-Id: I2929e11adc048af58b451892bae1c5789af8dcf0

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3840

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3840
Committed: http://gitorious.org/mahara/mahara/commit/969b2a6fe7bb2dd43538106e5e9b5230133eb8e3
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 969b2a6fe7bb2dd43538106e5e9b5230133eb8e3
Author: Aaron Wells <email address hidden>
Date: Mon Oct 20 09:44:50 2014 +1300

Marking a page objectionable caused it to be hidden

Bug 1298646: Objectionable pages are meant to remain visible
to users until an admin comes along and deletes them. They were
accidentally being hidden due to a bug in the logic flow in
can_view_view()

Change-Id: I2929e11adc048af58b451892bae1c5789af8dcf0

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Haha whoops, patches https://reviews.mahara.org/3834 and https://reviews.mahara.org/3840 were actually for bug 1383029! I put the wrong bug number in the commit message.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers