Site settings choosing search type problem

Bug #1298553 reported by Robert Lyon on 2014-03-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Patrick O'Keeffe

Bug Description

If I change my site setting search option from internal to elasticsearch when elasticsearch is not installed correctly I get a warning message about this -which is all good - but if I then hit save again it says saved ok.

The problem is - the check on the search only triggers if I'm changing from one type to another rather than checking on the search type when saving the page no matter what.

It would be better to test every time the site settings is saved just in case the search server has gone away for some reason - as it will allow a sysadmin to see the message here even if they are not knowing the search server is unreachable.

Aaron Wells (u-aaronw) on 2014-09-10
Changed in mahara:
milestone: 1.10.0 → 1.11.0
tags: added: academy
Changed in mahara:
assignee: nobody → Patrick O'Keeffe (patrickoke)
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/4157
Committed: http://gitorious.org/mahara/mahara/commit/406b9a8a45bcfeab037cae6c235fba4a65bc3d1b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 406b9a8a45bcfeab037cae6c235fba4a65bc3d1b
Author: Patrick O'Keeffe <email address hidden>
Date: Tue Jan 13 12:49:02 2015 +1300

patch for forcing search plugin check (bug 1298553)

Change-Id: I001850f421e3520ee17a8afbcfb2811ff213eec4

Robert Lyon (robertl-9) on 2015-01-14
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers