error when deleting a journal entry

Bug #1287922 reported by Robert Lyon on 2014-03-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.10
High
Robert Lyon
1.9
High
Unassigned

Bug Description

[WAR] c9 (artefact/blog/lib.php:911) Missing argument 2 for ArtefactTypeBlogPost::delete_form(), called in /home/robertl/htdocs/mahara-testing/mahara/htdocs/artefact/blog/view/index.php on line 29 and defined

This is caused by commit: b7063ffa2ec27ca500b74bef971c1bf28c16cdf8

ArtefactTypeBlog::delete_form has default $title = ''
but the ArtefactTypeBlogpost does not

So will fix.

tags: added: regression
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3210

Robert Lyon (robertl-9) wrote :

https://reviews.mahara.org/#/c/3210/

Also have the entry count updating on deleting an item

Son Nguyen (ngson2000) on 2014-04-09
Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/3210
Committed: http://gitorious.org/mahara/mahara/commit/ac1f8f084569de00528c88547c1136e390a38074
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ac1f8f084569de00528c88547c1136e390a38074
Author: Robert Lyon <email address hidden>
Date: Tue Apr 8 13:04:07 2014 +1200

Entry count updates on deletion of journal entry (Bug #1287922)

Before the count was only updating on page relaod - now it updates on
ajaxy delete.

Change-Id: I7a37f9322b2a55e55a7eed18fb05ee44f6561e36
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/3243
Committed: http://gitorious.org/mahara/mahara/commit/42a9d24c5e034225bc7a457fb7619385c300476f
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit 42a9d24c5e034225bc7a457fb7619385c300476f
Author: Robert Lyon <email address hidden>
Date: Tue Apr 8 13:04:07 2014 +1200

Entry count updates on deletion of journal entry (Bug #1287922)

Before the count was only updating on page relaod - now it updates on
ajaxy delete.

Change-Id: I7a37f9322b2a55e55a7eed18fb05ee44f6561e36
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) on 2014-10-20
Changed in mahara:
milestone: 1.10.0 → none
Aaron Wells (u-aaronw) on 2014-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers