double call of language_select_form()

Bug #1286941 reported by Robert Lyon on 2014-03-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon
1.8
Medium
Unassigned

Bug Description

Double call of language_select_form() throws error

Some things like die_info() will try and create a smarty() call when
we are already in one, which causes language_select_form() to throw
headdata error as it is called twice and can't be due to the form
having a select field in it and select fields love to add data to the
$HEADDATA.

Reviewed: https://reviews.mahara.org/3061
Committed: http://gitorious.org/mahara/mahara/commit/1968412b66216abc6e249401bce5c1c3e32ddd56
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1968412b66216abc6e249401bce5c1c3e32ddd56
Author: Robert Lyon <email address hidden>
Date: Mon Mar 3 13:10:58 2014 +1300

Double call of language_select_form() throws error (bug #1286941)

Some things like die_info() will try and create a smarty() call when
we are already in one, which causes language_select_form() to throw
headdata error as it is called twice and can't be due to the form
having a select field in it and select fields love to add data to the
$HEADDATA.

Made it so that it is only called once.

Change-Id: Ie2099dfc1990c8bd2a039bdd33869d9b65c156f1
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) on 2014-03-03
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released

Reviewed: https://reviews.mahara.org/4018
Committed: http://gitorious.org/mahara/mahara/commit/74cdf31bdffa5bd6045f959bfd94df7850c9fc29
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.8_STABLE

commit 74cdf31bdffa5bd6045f959bfd94df7850c9fc29
Author: Robert Lyon <email address hidden>
Date: Mon Mar 3 13:10:58 2014 +1300

Double call of language_select_form() throws error (bug #1286941)

Some things like die_info() will try and create a smarty() call when
we are already in one, which causes language_select_form() to throw
headdata error as it is called twice and can't be due to the form
having a select field in it and select fields love to add data to the
$HEADDATA.

Made it so that it is only called once.

Change-Id: Ie2099dfc1990c8bd2a039bdd33869d9b65c156f1
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers