Block configuration dialog is inconsistent width

[Jono M]

In Mahara 1.8 the block configuration dialog is fairly narrow and expands to fit its content (if there is a file browser, HTML editor, etc.) In latest master the dialog can be anything from very narrow (where it cuts off the edge of the file browser) to very wide (where it fills the screen and leaves massive amounts of white space everywhere). I can't reliably reproduce any of these widths.
This is probably an issue in setDialogPosition() in views.js, which was changed when the page editor was made keyboard-accessible.

I've attached a couple of screenshots showing this inconsistency (not the most extreme examples, but you get the idea ...)

[Kristina Hoeppner (kris-hoeppner)]

We've been having this issue for some time. I believe it was some Javascript not working out well.

[Nigel Cunningham (nigelc-g)]

Hi Son.

Are you still working on this? I'm looking at bugs to address while waiting on other tasks :)

Nigel

[Nigel Cunningham (nigelc-g)]

I'm unable to reproduce this with current HEAD on the Master branch.

[Son Nguyen (ngson2000)]

Currently, the width of the configuration dialogue is calculated based on its content width. As its content can be dynamically loaded e.g. the file picker/browser, the dialogue width should be changed to make enough room to display. That's why its width is not consistent.

[Aaron Wells (u-aaronw)]

Marking this incomplete because we haven't got a specific reproducible test case for the current HEAD.

[Robert Lyon (robertl-9)]

This patch, that has been merged, deals with configure dialog being more flexible depending on viewport size allowing the configure dialog to work better for mobile devices

https://reviews.mahara.org/#/c/3728/

So will mark this as resolved