Suspended user login attempts show up in "Online Users" list
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Mahara |
Medium
|
Aaron Wells | ||
| 1.8 |
Medium
|
Aaron Wells |
Bug Description
When a suspended user attempts to log in, if they enter their password correctly they see a message telling them they've been suspended, and the suspension reason the admin entered. They're also immediately logged out.
The bug is that this unsuccessful login attempt updates their "lastlogin" and "lastaccess" database fields. And that makes them show up in the "Online Users" sideblock, even though they shouldn't show up because they're not able to get in and do anything in the site.
Changed in mahara: | |
milestone: | none → 1.8.2 |
status: | New → Confirmed |
Aaron Wells (u-aaronw) wrote : | #2 |
Note: This patch is already in place on mahara.org
description: | updated |
Reviewed: https:/
Committed: http://
Submitter: Robert Lyon (<email address hidden>)
Branch: master
commit e700f2df82b3eb0
Author: Aaron Wells <email address hidden>
Date: Wed Feb 26 12:53:07 2014 +1300
Don't update "lastaccess" and "lastlogin" when login fails due to being suspended
Change-Id: Ic7c116dd09b501
no longer affects: | mahara/1.7 |
no longer affects: | mahara/1.6 |
Patch for "1.8_STABLE" branch: https:/
Reviewed: https:/
Committed: http://
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.8_STABLE
commit 3040d81e52b95ce
Author: Aaron Wells <email address hidden>
Date: Wed Feb 26 12:53:07 2014 +1300
Don't update "lastaccess" and "lastlogin" when login fails due to being suspended
Change-Id: Ic7c116dd09b501
Changed in mahara: | |
status: | Fix Committed → Fix Released |
no longer affects: | mahara/1.9 |
Patch for "master" branch: https:/ /reviews. mahara. org/3045