Skin edit form should use responsive tabs

Bug #1280009 reported by Jono Mingard on 2014-02-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Jono Mingard

Bug Description

In most places around the site the tabs collapse when the viewport width is too low to show all of them. This isn't the case in the Skins form.
profile.js already contains an implementation of this, so this could either be copied or (my preference) refactored into a standalone 'JS tabs' component

Affects latest master

Jono Mingard (mingard) on 2014-02-17
Changed in mahara:
assignee: nobody → Jono Mingard (mingard)
Jono Mingard (mingard) on 2014-02-17
Changed in mahara:
importance: Undecided → Medium
milestone: none → 1.9.0
Jono Mingard (mingard) on 2014-02-17
Changed in mahara:
status: New → In Progress

Reviewed: https://reviews.mahara.org/3015
Committed: http://gitorious.org/mahara/mahara/commit/8fe51b60fc6720790e410dbf49d736a564970233
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 8fe51b60fc6720790e410dbf49d736a564970233
Author: Jono Mingard <email address hidden>
Date: Mon Feb 17 09:42:58 2014 +1300

Make tabs in skin designer responsive (Bug #1280009)

- Refactor profile and skin designer tabs into one file which is used by both pages
- Change responsive navigation to take into account the preferred width of the tabs
(since the tabs in the skin designer are too wide for the normal responsive styles)

Change-Id: I00fc4c6a629c93804b4f3bdea1fcdf6233c53f99
Signed-off-by: Jono Mingard <email address hidden>

Robert Lyon (robertl-9) on 2014-04-14
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers