Change default license text in Journal blocktypes

Bug #1279526 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Kristina Hoeppner

Bug Description

When viewing a journal entry from a page (eg. by clicking on the title of a "Journal entry" block), if licenses are turned on and a license has not been selected the text "None selected" appears at the bottom of the page. However, there's no indication of context for this message - "None selected" could refer to anything.
It should be made in some way more obvious what this means - the text could be hidden entirely if no license is selected, the text could be changed to something like "No license has been selected for this journal entry", or a "License: " label could be added.

Affects latest master

Tags: usability
Jono M (jonom)
Changed in mahara:
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Jono Mingard (mingard)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3006

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3006
Committed: http://gitorious.org/mahara/mahara/commit/4237fd584db7a9609afdf15cf59f57190d884305
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4237fd584db7a9609afdf15cf59f57190d884305
Author: Jono Mingard <email address hidden>
Date: Thu Feb 13 16:56:01 2014 +1300

Change default text when rendering license (Bug #1279526)

Changed the "None selected" license text used when an artefact renders
itself (eg. when clicking on the title of a blocktype) to a more
descriptive version

Change-Id: Ie6c11f13660ebb50d316ed78ae4807cc1559ad6d
Signed-off-by: Jono Mingard <email address hidden>

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

The lang string "You have not chosen a license for this content" is not correct. If you have not chosen a license, the standard copyright takes effect.

Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 1.9.0
status: Fix Committed → In Progress
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.9.0 → 1.10.0
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.10.0 → 1.11.0
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 15.04.0 → 15.04.1
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 15.04.1 → 15.10.0
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Basically, "None selected" means that standard copyright applies.

Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 15.10.0 → 16.04.0
Changed in mahara:
assignee: Jono Mingard (mingard) → Kristina Hoeppner (kris-hoeppner)
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 16.04.0 → 16.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6411

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6411
Committed: https://git.mahara.org/mahara/mahara/commit/7943364a24575d39cb72b69f938926b57341261c
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 7943364a24575d39cb72b69f938926b57341261c
Author: Aaron Wells <email address hidden>
Date: Thu Apr 28 12:30:46 2016 +1200

Clarify that "no license chosen" means default copyright

Bug 1279526

behatnotneeded: Covered by existing tests

Change-Id: Ifc707fe735e090a2756468e93bcdedd8cd80d7a7

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: usermanualupdate
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
tags: removed: usermanualupdate
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.