Checkboxes when editing permissions for a page need labels

Bug #1278216 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jono M

Bug Description

For people using screen readers, having a label for every form input is essential as they have no other (easy) way of knowing what the input is for. Currently when editing permissions for a page, the labels next to the checkboxes to select which pages/collections to update don't use the <label> tag.
The essential problem here is that the <label> tag is used for headings on this page, so that style needs to be applied to some heading tag instead so that labels can be used for their semantic purpose.

Affects latest master

Jono M (jonom)
Changed in mahara:
status: New → In Progress
assignee: nobody → Jono Mingard (mingard)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/2994

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2994
Committed: http://gitorious.org/mahara/mahara/commit/e38c0153ea96f7a4120c26b42fa3203c6ae92c18
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit e38c0153ea96f7a4120c26b42fa3203c6ae92c18
Author: Jono Mingard <email address hidden>
Date: Mon Feb 10 14:42:17 2014 +1300

Use labels in checkboxes pieforms element (Bug #1278216)

Also added styles to keep formatting the same

Change-Id: If96a92c3c9db6465fc7f339148874e4e326a76fb
Signed-off-by: Jono Mingard <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.