Edit and delete buttons need descriptive alt text

Bug #1276397 reported by Jono Mingard on 2014-02-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Jono Mingard

Bug Description

To be accessible to screen readers, all images and image-like elements need an alt attribute specified. One area where this is not the case is edit and delete buttons.

- In the Journal, Delete buttons have a title attribute but no alt attribute (they need both)
- Notes is the same
- Delete buttons in Resume composite forms have alt="[x]" which should be changed to something more descriptive
- Manage tasks buttons in Plans use a missing string for alt text
- Edit and Delete buttons in group Forums have no alt attribute specified (same in Topics)

Ideally most of these should include the name of the thing to be edited/deleted in the alt text, eg. "Edit 'My plan'", since sometimes the editing buttons appear above the name of the thing to be deleted (in the HTML source) and sometimes they appear below.

Changed in mahara:
status: New → Confirmed
Jono Mingard (mingard) on 2014-02-06
Changed in mahara:
assignee: nobody → Jono Mingard (mingard)
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/2988
Committed: http://gitorious.org/mahara/mahara/commit/b7063ffa2ec27ca500b74bef971c1bf28c16cdf8
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b7063ffa2ec27ca500b74bef971c1bf28c16cdf8
Author: Jono Mingard <email address hidden>
Date: Fri Feb 7 09:49:51 2014 +1300

Add descriptive alt text to Edit and Delete buttons (Bug #1276397)

Edit and Delete buttons should now have consistent, descriptive alt text -
where possible this includes the title of the object to be edited or deleted

Change-Id: Ic10775c961a27c8e1ce1fcc011be1f6c46ee9c1f
Signed-off-by: Jono Mingard <email address hidden>

Ruslan Kabalin (rkabalin) wrote :

With this patch, the forum topics page looks broken for me.

Jono Mingard (mingard) wrote :

I can replicate the problem on Chrome (doesn't happen on Firefox). Thanks for letting me know, I'll get a fix out ASAP

Reviewed: https://reviews.mahara.org/3026
Committed: http://gitorious.org/mahara/mahara/commit/b0c2f60ebfc3852d8656e92dcba9a26c207f5ebd
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit b0c2f60ebfc3852d8656e92dcba9a26c207f5ebd
Author: Jono Mingard <email address hidden>
Date: Thu Feb 20 10:09:03 2014 +1300

Fixed display of edit and delete buttons (Bug #1276397)

The previous patch for this bug caused miniature text to be overlaid on
buttons in the list of forum topics. Adding text-align: left fixes it

Change-Id: Id6b7325f00cc8f497677dc1092aad3c701aa3ed0
Signed-off-by: Jono Mingard <email address hidden>

Robert Lyon (robertl-9) on 2014-02-25
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers