Skins form needs to use label elements

Bug #1273937 reported by Jono Mingard on 2014-01-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Jono Mingard

Bug Description

Child of Bug #1259756

Currently the form to add/edit a skin has labels for most elements, but since they do not use the <label> tag they are not accessible to screen reader users.
Also, the direction pickers (for background position etc.) need hidden labels.

Affects latest master

(WCAG Level A)

Reviewed: https://reviews.mahara.org/2973
Committed: http://gitorious.org/mahara/mahara/commit/2401c8844492b7c5e7cd51db3c79e3187bd1edea
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 2401c8844492b7c5e7cd51db3c79e3187bd1edea
Author: Jono Mingard <email address hidden>
Date: Wed Jan 29 16:51:43 2014 +1300

Use <label> tags in skin designer (Bug #1273937)

Changed 'labelhtml' to 'title' in skin design form to allow the input
labels to use the <label> tag and therefore be accessible to screen
readers.
Modified the position choosers to have hidden labels and (hopefully)
fixed cross-browser inconsistencies in the layout.
Also modified the structure of the radio pieforms element to fix issues
with screen readers.

Change-Id: I8706c34e2c2a86b0f3d54b5f0c54d337ecc251a6
Signed-off-by: Jono Mingard <email address hidden>

Son Nguyen (ngson2000) on 2014-02-10
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints