Focus should be set to search results if loaded with AJAX (Administration)

Bug #1267296 reported by Jono Mingard on 2014-01-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Robert Lyon

Bug Description

Split from Bug #1266923 since this is lower priority.

When searching for content in Mahara's Administration section, most of the time the search results are loaded with Javascript, so to a screen reader user it seems like nothing happens when pressing the search button. Examples include
- Users -> User search
- Groups -> Administer groups
- Institutions
- Users -> Site staff (and site admins, institution staff, etc.)

When the search button is pressed, focus should be set to the first search result (or somewhere else logical, like the results heading).

Affects latest master

Jono Mingard (mingard) wrote :

Note that the patch for Bug #1266923 now modifies pagination.js rather than each individual page, so some of these may be fixed or partially fixed already.

Robert Lyon (robertl-9) wrote :

The examples:
- Users -> User search
- Groups -> Administer groups
- Institutions

Look to be fixed now (via Bug #1266923)

Robert Lyon (robertl-9) on 2014-03-09
Changed in mahara:
milestone: none → 1.9.0
assignee: nobody → Robert Lyon (robertl-9)
status: New → In Progress
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3088

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3091

Robert Lyon (robertl-9) wrote :

Will mark committed as the 3 patches relating to this are now merged

Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) wrote :

I've reopened this bug as I see there is a fix for some more places - groups and institutions
https://reviews.mahara.org/#/c/3110

Changed in mahara:
status: Fix Committed → In Progress

Reviewed: https://reviews.mahara.org/3111
Committed: http://gitorious.org/mahara/mahara/commit/751f4ffdaa0e81f6c4b40f752d2c4048251ca039
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 751f4ffdaa0e81f6c4b40f752d2c4048251ca039
Author: Son Nguyen <email address hidden>
Date: Tue Mar 25 11:53:51 2014 +1300

Set focus to the results after search (Bug 1267296)

in the pages
- Group/Pages
- Institutions/Pages

Change-Id: I6adbaa4037b2e478a3277c3f62574dcdd00efbdd
Signed-off-by: Son Nguyen <email address hidden>

Robert Lyon (robertl-9) on 2014-04-08
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers