Clicking on new change layout icon needs to warn if navigating away without saving

Bug #1267240 reported by Robert Lyon on 2014-01-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Unassigned
1.8
Low
Unassigned
1.9
Low
Unassigned

Bug Description

Need to set page layout form as dirty when changing layouts by clicking on layout thumbnail instead of radio button.

To test:
1) Create page and go to 'Edit Layout' page
2) Change layout option by clicking a radio button of the new layout your want - try to navigate away - get prompted to save
3) Save
4) go to 'Edit Layout' page again
5) change layout option by clicking on the icon image of the new layout you want - try to navigate away - NO PROMPT but we should be prompted.

Reviewed: https://reviews.mahara.org/2891
Committed: http://gitorious.org/mahara/mahara/commit/ac96f0d961409dbe9bb52403142ce2690f37a8b4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ac96f0d961409dbe9bb52403142ce2690f37a8b4
Author: Mike Kelly <email address hidden>
Date: Wed Jan 8 16:38:43 2014 +0000

Set layout form as dirty when changing layouts via icon (bug #1267240)

by clicking on layout thumbnail instead of radio button

Change-Id: I58f723f47ff71f4e4d3dbfda7c5ad1e39372e916
Signed-off-by: Mike Kelly <email address hidden>

Robert Lyon (robertl-9) on 2014-01-09
Changed in mahara:
status: Confirmed → Fix Committed

Reviewed: https://reviews.mahara.org/3078
Committed: http://gitorious.org/mahara/mahara/commit/5da93b1deec85eaa8a5d0125091d712e96386488
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.8_STABLE

commit 5da93b1deec85eaa8a5d0125091d712e96386488
Author: Mike Kelly <email address hidden>
Date: Wed Jan 8 16:38:43 2014 +0000

Set layout form as dirty when changing layouts via icon (bug #1267240)

by clicking on layout thumbnail instead of radio button

Change-Id: I58f723f47ff71f4e4d3dbfda7c5ad1e39372e916
Signed-off-by: Mike Kelly <email address hidden>

Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers