Pieforms date elements should have "Not specified" before the date picker

Bug #1265091 reported by Jono Mingard on 2013-12-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Jono Mingard
Mahara user manual
Medium
Kristina Hoeppner

Bug Description

The pieforms date picker (in lib/pieforms/pieform/elements/date.php) can have both a date picker (set of comboboxes) and a "Not specified" checkbox. However, it's confusing to screen reader users that the date comboboxes are displayed before the "Not specified" checkbox because if the comboboxes are disabled (ie. if the checkbox is initially checked) then they are not read out - so if a screen reader user unchecks the checkbox they have to tab backwards to get to the date selector.
The position of the comboboxes and checkbox should be swapped so that when the checkbox is unchecked, the comboboxes are next in the tab order.

The same goes for the "expiry" element - in this case the combobox should be displayed before the text box.

Affects latest master

Jono Mingard (mingard) on 2013-12-31
description: updated
summary: - Pieforms date element should have "Not specified" before the date picker
+ Pieforms date elements should have "Not specified" before the date
+ picker
Jono Mingard (mingard) on 2014-01-15
tags: added: academy
Jono Mingard (mingard) wrote :

The same goes for colour pickers (in Skins) and maybe other elements as well

Jono Mingard (mingard) on 2014-02-05
Changed in mahara:
status: New → In Progress
assignee: nobody → Jono Mingard (mingard)

Reviewed: https://reviews.mahara.org/2984
Committed: http://gitorious.org/mahara/mahara/commit/7d91d9477c60dfc6eb0e8af59e44e5ffbfed3caa
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 7d91d9477c60dfc6eb0e8af59e44e5ffbfed3caa
Author: Jono Mingard <email address hidden>
Date: Tue Feb 4 17:37:47 2014 +1300

Redesigned elements with optional checkbox (Bug #1265091)

Color picker (used in skin designer) - moved 'transparent' checkbox
before color input field and changed the label to 'Custom'
Date picker - moved 'Not specified' checkbox before comboboxes and
changed the label to 'Set date'

Change-Id: I12e779cfdc06268f0f2ff494bf0753e066558686
Signed-off-by: Jono Mingard <email address hidden>

Son Nguyen (ngson2000) on 2014-02-20
Changed in mahara:
status: In Progress → Fix Committed
Jono Mingard (mingard) on 2014-02-26
Changed in mahara:
status: Fix Committed → In Progress

Reviewed: https://reviews.mahara.org/3047
Committed: http://gitorious.org/mahara/mahara/commit/6ec3f3d8a5de9cad6f9efa4322da01c1d3006cbb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6ec3f3d8a5de9cad6f9efa4322da01c1d3006cbb
Author: Jono Mingard <email address hidden>
Date: Wed Feb 26 16:55:17 2014 +1300

Display 'Set date' checkbox when date selector doesn't include time (Bug #1265091)

The earlier patch for this bug introduced this issue - see "Account settings"
for an example

Change-Id: Ia899d167f28e713d1a17808d55ebf54f6dbf027a
Signed-off-by: Jono Mingard <email address hidden>

Robert Lyon (robertl-9) on 2014-02-27
Changed in mahara:
milestone: none → 1.9.0
status: In Progress → Fix Committed
tags: added: usermanualupdate
Changed in mahara-manual:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Kristina Hoeppner (kris-hoeppner)
milestone: none → 1.9.0
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
Changed in mahara-manual:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints