Set up an institution_config table for configuring institutions

Bug #1264429 reported by Aaron Wells on 2013-12-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Unassigned

Bug Description

We've been adding a lot of new institution configuration parameters lately, so it makes sense to add an "institution_config" table to handle these so that we don't have to add a new column to the "institution" table each time we want to add some new bit of configuration.

This can be integrated into the Institution class and the get_config_institution() methods so that the programmer accessing the field doesn't need to know whether it's in the "institution" table or the "institution_config" table.

Reviewed: https://reviews.mahara.org/2870
Committed: http://gitorious.org/mahara/mahara/commit/5be3b920903cd00da4f837064928364a70430124
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5be3b920903cd00da4f837064928364a70430124
Author: Aaron Wells <email address hidden>
Date: Fri Dec 27 16:39:19 2013 +1300

Introducing the institution_config table

Bug 1264429: This patch creates the table, refactors the get_institution_config() method,
the Institution class, and the institution editing page, to use the new table.

Henceforth columns should only be added to the main "institution" table if they represent
a required setting (like name and displayname), or they need to be accessed frequently by
direct SQL queries.

Change-Id: I4564240d2c55ec2b6ec90868290a61cf4321460a

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2892
Committed: http://gitorious.org/mahara/mahara/commit/3fdda55947e3b6b723c0ac350cdec803f31af8d6
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 3fdda55947e3b6b723c0ac350cdec803f31af8d6
Author: Jono Mingard <email address hidden>
Date: Thu Jan 9 09:19:28 2014 +1300

Use global $CFG in get_configs_user_institutions() (Bug #1264429)

The get_configs_user_institutions() method used the global $CFG variable
without declaring it, causing warnings when trying to set a property of it

Change-Id: Id02edcf735ffc3c8a779dc787715a6ba20626af1
Signed-off-by: Jono Mingard <email address hidden>

Is there anything else that needs to be done here or is the status of "Fix committed" that I just placed OK?

Changed in mahara:
importance: Undecided → Medium
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers