Collection Navigation should be a list not a table

Bug #1264014 reported by Melissa Newman on 2013-12-25
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Jono Mingard

Bug Description

The block navigation, the html code is a table, when it should be an unordered list. The advantage of it being a list is that it will allow a user to apply skins to the navigation.

Attached is the file that needs to be modified in

blocktype/navigation/theme/raw/navigation.tpl

Also, the CSS needs to be updated with something along the following lines, or else the default will be a bullet list.

nav ul{
    list-style: none;
}
nav ul li:before{
    content: "\00BB \0020";
    font-size: 12pt;
}
nav ul li h3 {
    display: inline;
}

This will also need to be looked at with the eye for accessibility. Added Jono so he can comment as well.

tags: added: css
removed: collections menu navigation
Changed in mahara:
milestone: none → 1.9.0
importance: Undecided → Medium
status: New → Confirmed
tags: added: patch-included
Jono Mingard (mingard) wrote :

This looks good, having it as a list will make it a lot more accessible.

Jono Mingard (mingard) on 2014-02-18
Changed in mahara:
assignee: nobody → Jono Mingard (mingard)
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/3018
Committed: http://gitorious.org/mahara/mahara/commit/ab3d306df2a2e92c033149fb113a49f0d2539d46
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ab3d306df2a2e92c033149fb113a49f0d2539d46
Author: Jono Mingard <email address hidden>
Date: Tue Feb 18 16:10:09 2014 +1300

Changed navigation block from table to list (Bug #1264014)

Uses the same styles as the old version rather than the modified ones from
the bug report

Change-Id: I1784608b125cdcad7acad8bb9ade69f7973a01f6
Signed-off-by: Jono Mingard <email address hidden>

Robert Lyon (robertl-9) on 2014-02-25
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers