Add buttons in "Edit Access" should have more descriptive text

Bug #1262490 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Jono M

Bug Description

When sharing a page or collection (/view/access.php), there are multiple "Add" buttons on the screen to give access to Logged-in users, the general public, etc. This is confusing for screen reader users since if you tab through the links with a screen reader there is no way to tell which "Add" button you are focused on.
The text of the add buttons should be changed to include what they are adding, eg. "Add Logged-in users" or even "Allow access for Logged-in users"

Affects latest master

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

I'd prefer "Add access for logged-in users" etc. as that is more specific for the action that you are performing.

When you have institutions, it could say "Add access for institution XYZ" and when groups "Add access for group ABC".

Changed in mahara:
status: New → Confirmed
Jono M (jonom)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Jono Mingard (mingard)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/2978

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2978
Committed: http://gitorious.org/mahara/mahara/commit/3c4d4a2f8495a64193624e71c84954a605762fbc
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3c4d4a2f8495a64193624e71c84954a605762fbc
Author: Jono Mingard <email address hidden>
Date: Mon Feb 3 17:46:24 2014 +1300

Added descriptive text to buttons in Edit access (Bug #1262490)

Changed text from "Add" to a descriptive alternative based on whether
you're giving a group, institution or people access.

Change-Id: I3082aefb77ee9279f4d85f27ba9e33a555d3094b
Signed-off-by: Jono Mingard <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 1.9.0
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.