All form elements need labels

Bug #1259756 reported by Jono Mingard on 2013-12-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Jono Mingard
16.10
Medium
Unassigned
17.04
Medium
Jono Mingard

Bug Description

Parent bug: Please make a new bug report for each section that is fixed which references this bug in the description, and add a comment here with the new bug number.

For people using screen readers, having a label for every form input is essential as they have no other (easy) way of knowing what the input is for. Currently there are various form fields in Mahara which do not have labels, so either existing labels need to be linked to these inputs or new (hidden) ones need to be created.

- "Upload file" in Content -> Profile -> Files [DONE]
- New folder name input in Content -> Profile -> Files [DONE]
- Radio buttons in email selector [now in Bug #1277297]
- Pagination combobox [now in Bug #1277276]
- Profile picture radio buttons and checkboxes [DONE]
- "Attach file" labels in Content -> Resume [now in Bug #1277290]
- Collection and page checkboxes when editing permissions for a group [now in Bug #1278216]
- Cookie consent -> Types of cookies checkboxes [part of Bug #1278216]
- Portfolio -> Skins (the whole form, particularly the 8-direction placement elements) [now in Bug #1273937]
- Administration -> Fonts (similar issues to Skins)
- Non-JS radio buttons in the page editor [part of Bug #1262933]
- "Add a new entry to ..." combo box in Journal entries block (multiple journals only)
- "Ignore" and "Add new" radio buttons used when importing [now in Bug #1278238]

Affects latest master

(WCAG Level A)

Jono Mingard (mingard) on 2013-12-12
Changed in mahara:
importance: Undecided → High
Jono Mingard (mingard) wrote :

Moved high-priority labels into Bug #1262867 and Bug #1262870

description: updated
Changed in mahara:
importance: High → Medium
Jono Mingard (mingard) on 2013-12-29
description: updated
Jono Mingard (mingard) wrote :

Added low-priority labels to a new report - Bug #1265099

Reviewed: https://reviews.mahara.org/2945
Committed: http://gitorious.org/mahara/mahara/commit/b8aad2783fe05570b789c87faef0af6aa9e80d50
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b8aad2783fe05570b789c87faef0af6aa9e80d50
Author: Jono Mingard <email address hidden>
Date: Tue Jan 21 15:32:05 2014 +1300

Fixed labels in file browser (Bug #1259756)

Added labels to Edit and Delete buttons, Create folder input. Fixed labels
in License info not being linked to their inputs correctly.

Change-Id: I3d44845c270dbbaf9158b4e58bed6353ae412cfc
Signed-off-by: Jono Mingard <email address hidden>

Spun off Bug #1271301 for search and filter forms

description: updated
description: updated
Jono Mingard (mingard) on 2014-01-22
Changed in mahara:
assignee: nobody → Jono Mingard (mingard)
status: New → In Progress
Jono Mingard (mingard) on 2014-01-22
description: updated
Changed in mahara:
milestone: none → 1.9.0
Jono Mingard (mingard) on 2014-01-27
summary: - Not all form elements have labels
+ [Ongoing] All form elements need labels
description: updated

Reviewed: https://reviews.mahara.org/2956
Committed: http://gitorious.org/mahara/mahara/commit/777ffb4f2a30ac6477ba8639ef55301379df7724
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 777ffb4f2a30ac6477ba8639ef55301379df7724
Author: Jono Mingard <email address hidden>
Date: Fri Jan 24 14:21:56 2014 +1300

Added labels to profile picture controls (Bug #1259756)

Hidden "Set default" and "Mark for deletion" labels for radio buttons and
checkboxes in profile picture rows.

Change-Id: I668e68f74df6c5cbe925145b81099e9ccf4b4eb3
Signed-off-by: Jono Mingard <email address hidden>

Jono Mingard (mingard) on 2014-02-03
description: updated
Jono Mingard (mingard) on 2014-02-03
description: updated
Jono Mingard (mingard) on 2014-02-06
description: updated
Jono Mingard (mingard) on 2014-02-06
description: updated
Jono Mingard (mingard) on 2014-02-07
description: updated
Jono Mingard (mingard) on 2014-02-10
description: updated
Jono Mingard (mingard) on 2014-02-10
description: updated
Jono Mingard (mingard) on 2014-02-10
description: updated
Aaron Wells (u-aaronw) on 2014-04-15
Changed in mahara:
milestone: 1.9.0 → 1.10.0

Patch 3085 was merged (though Mahara Bot didn't post an update about it)

Changed in mahara:
milestone: 1.10.0 → 1.11.0
Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
milestone: 15.04.0 → 15.04.1
Aaron Wells (u-aaronw) on 2015-04-21
Changed in mahara:
milestone: 15.04.1 → 15.10.0
Aaron Wells (u-aaronw) on 2015-10-23
Changed in mahara:
milestone: 15.10.0 → 16.04.0

Are there still any forms that are missing labels?

Aaron Wells (u-aaronw) on 2016-04-28
Changed in mahara:
milestone: 16.04.0 → 16.10.0
status: In Progress → Incomplete
Robert Lyon (robertl-9) on 2016-10-20
Changed in mahara:
milestone: 16.10.0 → 16.10.1
Robert Lyon (robertl-9) wrote :

Looking thru the outstanding items from initial comment they look to all be sorted out now

So will close this bug

summary: - [Ongoing] All form elements need labels
+ All form elements need labels
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints