HTML editor is not disabled when leaving feedback

Bug #1259373 reported by Jono Mingard on 2013-12-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Jono Mingard

Bug Description

When placing feedback on a page, TinyMCE is shown for entering the Message regardless of whether "HTML editor" is enabled in user settings. This is significant for accessibility since TinyMCE itself is not accessible to screen readers
It should be replaced by a plain textarea if HTML editor is disabled.

Affects latest master

Jono Mingard (mingard) on 2013-12-30
Changed in mahara:
importance: Undecided → Medium
description: updated
Jono Mingard (mingard) on 2013-12-31
Changed in mahara:
status: New → In Progress
Jono Mingard (mingard) on 2014-01-06
Changed in mahara:
assignee: nobody → Jono Mingard (mingard)

Reviewed: https://reviews.mahara.org/2855
Committed: http://gitorious.org/mahara/mahara/commit/e72166aa8ceb39d0e0198663edc5221fdbcad693
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e72166aa8ceb39d0e0198663edc5221fdbcad693
Author: Jono Mingard <email address hidden>
Date: Tue Dec 31 14:41:26 2013 +1300

Respect the user's HTML editor setting in Feedback (Bug #1259373)

If TinyMCE is enabled/disabled in the site settings it should always be
enabled/disabled for Feedback.

If TinyMCE is set to User-defined, it will only be enabled if the
logged-in user has enabled it in their user settings. This means it will
be disabled for anonymous users and people who've turned the HTML editor
off.

Change-Id: I5565e69574c65296067f7883b2e66c50a8f15919
Signed-off-by: Jono Mingard <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 1.9.0
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers