"Menu" is hardcoded when viewed on small device

Bug #1258970 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

When going down to a small device, the regular navigation bar collapses into "Menu". The string "Menu" is hardcoded into the template and thus can't be translated.

Revision history for this message
Robert Lyon (robertl-9) wrote :

https://reviews.mahara.org/#/c/2775
Added patch to fix hard coded strings

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Steven (stevens-q) wrote :

===== How to Test =====
1. BROWSE to the Mahara site and LOG IN using the following devices
 a. Android Tablet v4.2.2
 b. iPad Tablet v6.1 & v7.0.1
 c. iPhone Mobile Phone 5" v7.0.1
 d. Android Mobile Phone 5" v4.3

2. CONFIRM that the main navigation menu displays as a drop down menu on the following devices
 [x] Android Tablet - drop down menu not present - just a normal menu - both landscape & portrait orientation
 [x] iPad Tablet - menu is present as drop down menu but stays open - menu displays in Portrait orientation only- regular menu in landscape
 [✔] iPhone Mobile Phone - working correctly
 [✔] Android Mobile Phone - working correctly

Catalyst QA Failed Testing ✘

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

The two failed issues have been addressed in bug #1262892 as far as I can tell. This patch will probably need rebasing then.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2775
Committed: http://gitorious.org/mahara/mahara/commit/cfa495cbd83b8c6f2cb48d1104099b5f7751fde3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit cfa495cbd83b8c6f2cb48d1104099b5f7751fde3
Author: Robert Lyon <email address hidden>
Date: Mon Dec 9 11:32:49 2013 +1300

Stringifying some responsive design hard coded strings (bug 1258970)

Change-Id: I9fc343337f2e2cfc5fd1615f5839401bb58e0408
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.