copying collection needs to sort table by collection

Bug #1255780 reported by Robert Lyon on 2013-11-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon

Bug Description

Currently in Mahara if I have a collection (Portfolio -> Collections) and I click on the 'Copy a collection' button I am taken to view/choosetemplate.php?searchcollection=1 (which has Portfolio -> Pages menu highlighted rather than Portfolio -> Collections).

The table of results is ordered by page name rather than collection name, then page name.

From what I can tell the searchcollection=1 in the url does nothing.
Looking at the commit: 86d8cc21d40343cb4bcd4a827d0f55887a01f2ec
It never did anything but could be utilised to

a) have the Portfolio -> Collections menu highlighted instead of Portfolio -> Pages when coming from collections
b) make the table sort by collection, then pages instead of just pages

I feel these changes would make for better user experience

Another way to make things a bit easier to understand would be to have only one 'Copy collection' button in the table for each collection instead of one for each page in a collection. (similar to how Content -> Notes now works for which textboxes are in which pages).

See collection table mockup of what I mean

Robert Lyon (robertl-9) wrote :
Robert Lyon (robertl-9) on 2013-11-28
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Robert Lyon (robertl-9) wrote :

Have added a patch to allow for the sorting of the copy collections table by collection if coming from Portfolio -> Collections
https://reviews.mahara.org/#/c/2755/

- TODO: possibly limit each copyable collection to have one 'Copy
collection' button and have the alternating row colours toggle for
each collection rather than just each row.

Robert Lyon (robertl-9) on 2013-11-28
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
milestone: none → 1.9.0
Steven (stevens-q) wrote :

======Bugs======

[x] Highlighted Tab is not correct - highlighted tab should be the collections tab
[x] results Order should be based on collections and then by collection pages - A user will then be able to search for collections by name under which all of the collection pages will be listed

===== How to Test =====

1. LOG IN as an authenticated user
2. BROWSE to the collections tab (located under the portfolio tab)
3. CLICK on the copy a collection button
4. CONFIRM that the search results are first listed by collection name and then by pages that make up each collection
5. CONFIRM that the sub menu collections tab is highlighted when the user has navigated to the "Copy a page or collection" page from the collections page using the copy collection button.

===== Test Results =====

4. CONFIRM that the search results are first listed by collection name and then by pages that make up each collection ✔
5. CONFIRM that the sub menu collections tab is highlighted when the user has navigated to the "Copy a page or collection" page from the collections page using the copy collection button. ✔

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/2755
Committed: http://gitorious.org/mahara/mahara/commit/db4bc11bc4df8d322c8990c0a4f77158b7e7c422
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit db4bc11bc4df8d322c8990c0a4f77158b7e7c422
Author: Robert Lyon <email address hidden>
Date: Thu Nov 28 14:26:18 2013 +1300

Getting the copy a page or collection to sort by collection
Bug #1255780

When clicking the 'Copy a collection' button on the
Portfolio -> Collections page the list of copyable pages is sorted by
collection name rather than page name to make it easier to see what pages are
in the collection that you are about to copy.

Also the subheading highlighted is 'Collections' instead of 'Pages'.

When clicking the 'Copy a page' link in Portfolio -> Pages things
should work like before.

- TODO: possibly limit each copyable collection to have one 'Copy
collection' button and have the alternating row colours toggle for
each collection rather than just each row.

Change-Id: I4b9786ba95404e03f44039cacb6e6b4bf6a4b0d6
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2013-12-23
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2014-04-22
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers